Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: sky/engine/core/frame/LocalDOMWindow.cpp

Issue 646273006: Get rid of ScrollView. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: merge to ToT Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/frame/LocalDOMWindow.cpp
diff --git a/sky/engine/core/frame/LocalDOMWindow.cpp b/sky/engine/core/frame/LocalDOMWindow.cpp
index 9a3871b94cff58ac41a5effdf28f6d48daf94bf8..8e5a1d7f35ced136eeaf84bc89bd77b34ae18e39 100644
--- a/sky/engine/core/frame/LocalDOMWindow.cpp
+++ b/sky/engine/core/frame/LocalDOMWindow.cpp
@@ -241,15 +241,6 @@ PassRefPtrWillBeRawPtr<Document> LocalDOMWindow::installNewDocument(const Docume
m_frame->script().updateDocument();
m_document->updateViewportDescription();
-
- if (m_frame->page() && m_frame->view()) {
- if (ScrollingCoordinator* scrollingCoordinator = m_frame->page()->scrollingCoordinator()) {
- scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_frame->view(), HorizontalScrollbar);
- scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_frame->view(), VerticalScrollbar);
- scrollingCoordinator->scrollableAreaScrollLayerDidChange(m_frame->view());
- }
- }
-
return m_document;
}
@@ -678,14 +669,7 @@ static bool scrollBehaviorFromScrollOptions(const Dictionary& scrollOptions, Scr
void LocalDOMWindow::scrollBy(int x, int y, ScrollBehavior scrollBehavior) const
{
- document()->updateLayoutIgnorePendingStylesheets();
-
- FrameView* view = m_frame->view();
- if (!view)
- return;
-
- IntSize scaledOffset(x * m_frame->pageZoomFactor(), y * m_frame->pageZoomFactor());
- view->scrollBy(scaledOffset, scrollBehavior);
+ // FIXME(sky): Remove
}
void LocalDOMWindow::scrollBy(int x, int y, const Dictionary& scrollOptions, ExceptionState &exceptionState) const

Powered by Google App Engine
This is Rietveld 408576698