mojo/apps/js/v8_environment.cc - Issue 64623003: Fix win64 build failure on size truncation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/v8_environment.cc

Issue 64623003: Fix win64 build failure on size truncation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/apps/js/v8_environment.cc

===================================================================

--- mojo/apps/js/v8_environment.cc (revision 233919)

+++ mojo/apps/js/v8_environment.cc (working copy)

@@ -40,7 +40,7 @@

void InitializeV8() {

v8::V8::SetArrayBufferAllocator(new ArrayBufferAllocator());

v8::V8::InitializeICU();

- v8::V8::SetFlagsFromString(kFlags, strlen(kFlags));

+ v8::V8::SetFlagsFromString(kFlags, static_cast<uint32_t>(strlen(kFlags)));

viettrungluu 2013/11/08 19:02:10 I wonder if this shouldn't be using arraysize() in

jschuh 2013/11/08 19:28:12 It should, but I didn't think I could use base her

v8::V8::SetEntropySource(&GenerateEntropy);

v8::V8::Initialize();

}