Fix win64 build failure on size truncation

Fix win64 build failures on size truncation

R=viettrungluu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234731

[jschuh, 2013-11-08 17:21:23]

ptal

[jschuh, 2013-11-08 17:41:55]

On second thought, I'm going to try and fix all of these at once.

[jschuh, 2013-11-08 18:16:05]

Ok, now PTAL.

[viettrungluu, 2013-11-08 19:02:10]

LGTM with one thing fixed.

https://codereview.chromium.org/64623003/diff/170001/mojo/apps/js/v8_environm...
File mojo/apps/js/v8_environment.cc (right):

https://codereview.chromium.org/64623003/diff/170001/mojo/apps/js/v8_environm...
mojo/apps/js/v8_environment.cc:43: v8::V8::SetFlagsFromString(kFlags,
static_cast<uint32_t>(strlen(kFlags)));
I wonder if this shouldn't be using arraysize() instead. <shrug>

https://codereview.chromium.org/64623003/diff/170001/mojo/services/native_vie...
File mojo/services/native_viewport/native_viewport_controller.cc (right):

https://codereview.chromium.org/64623003/diff/170001/mojo/services/native_vie...
mojo/services/native_viewport/native_viewport_controller.cc:76:
assert((string.size() + 1) < std::numeric_limits<uint32_t>::max());
Here, you're allowed to use base, so you should probably just using DCHECK_LT
(and not include assert.h, and include base/logging.h).

https://codereview.chromium.org/64623003/diff/170001/mojo/system/message_pipe...
File mojo/system/message_pipe_unittest.cc (right):

https://codereview.chromium.org/64623003/diff/170001/mojo/system/message_pipe...
mojo/system/message_pipe_unittest.cc:217: for (int32_t i = 0; i < 5; i++) {
Hey, this was actually me! Oops.

[jschuh, 2013-11-08 19:28:12]

https://codereview.chromium.org/64623003/diff/170001/mojo/apps/js/v8_environm...
File mojo/apps/js/v8_environment.cc (right):

https://codereview.chromium.org/64623003/diff/170001/mojo/apps/js/v8_environm...
mojo/apps/js/v8_environment.cc:43: v8::V8::SetFlagsFromString(kFlags,
static_cast<uint32_t>(strlen(kFlags)));
On 2013/11/08 19:02:10, viettrungluu wrote:
> I wonder if this shouldn't be using arraysize() instead. <shrug>

It should, but I didn't think I could use base here.

https://codereview.chromium.org/64623003/diff/170001/mojo/services/native_vie...
File mojo/services/native_viewport/native_viewport_controller.cc (right):

https://codereview.chromium.org/64623003/diff/170001/mojo/services/native_vie...
mojo/services/native_viewport/native_viewport_controller.cc:76:
assert((string.size() + 1) < std::numeric_limits<uint32_t>::max());
On 2013/11/08 19:02:10, viettrungluu wrote:
> Here, you're allowed to use base, so you should probably just using DCHECK_LT
> (and not include assert.h, and include base/logging.h).

Done.

[commit-bot: I haz the power, 2013-11-08 19:31:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/64623003/240001

[commit-bot: I haz the power, 2013-11-09 01:24:29]

Failed to apply patch for mojo/public/bindings/lib/connector.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file mojo/public/bindings/lib/connector.cc
  Hunk #1 FAILED at 118.
  1 out of 1 hunk FAILED -- saving rejects to file
mojo/public/bindings/lib/connector.cc.rej

Patch:       mojo/public/bindings/lib/connector.cc
Index: mojo/public/bindings/lib/connector.cc
===================================================================
--- mojo/public/bindings/lib/connector.cc	(revision 233919)
+++ mojo/public/bindings/lib/connector.cc	(working copy)
@@ -118,7 +118,7 @@
                                  message->data,
                                  message->data->header.num_bytes,
                                  message->handles.data(),
-                                 message->handles.size(),
+                                
static_cast<uint32_t>(message->handles.size()),
                                  MOJO_WRITE_MESSAGE_FLAG_NONE);
     if (rv == MOJO_RESULT_OK) {
       // TODO(darin): Handles were successfully transferred, and so we need

[commit-bot: I haz the power, 2013-11-09 15:00:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/64623003/240001

[commit-bot: I haz the power, 2013-11-09 15:00:15]

Failed to apply patch for mojo/public/bindings/lib/connector.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file mojo/public/bindings/lib/connector.cc
  Hunk #1 FAILED at 118.
  1 out of 1 hunk FAILED -- saving rejects to file
mojo/public/bindings/lib/connector.cc.rej

Patch:       mojo/public/bindings/lib/connector.cc
Index: mojo/public/bindings/lib/connector.cc
===================================================================
--- mojo/public/bindings/lib/connector.cc	(revision 233919)
+++ mojo/public/bindings/lib/connector.cc	(working copy)
@@ -118,7 +118,7 @@
                                  message->data,
                                  message->data->header.num_bytes,
                                  message->handles.data(),
-                                 message->handles.size(),
+                                
static_cast<uint32_t>(message->handles.size()),
                                  MOJO_WRITE_MESSAGE_FLAG_NONE);
     if (rv == MOJO_RESULT_OK) {
       // TODO(darin): Handles were successfully transferred, and so we need

[commit-bot: I haz the power, 2013-11-13 00:33:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/64623003/570001

[commit-bot: I haz the power, 2013-11-13 03:09:11]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-13 03:21:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jschuh@chromium.org/64623003/570001

[commit-bot: I haz the power, 2013-11-13 03:40:59]

Change committed as 234731