src/core/SkCanvas.cpp - Issue 646213003: Add `SkIRect bounds()` convenience method to SkImageInfo and SkBitmap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkCanvas.cpp

Issue 646213003: Add `SkIRect bounds()` convenience method to SkImageInfo and SkBitmap. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: sorted headers Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkCanvas.cpp

diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp

index 2f7fcf4d4b5b5110ebf490cc33d14cc0cac15086..7b0e6428dfc597b69b7b60633fd4d6b2b634d520 100644

--- a/src/core/SkCanvas.cpp

+++ b/src/core/SkCanvas.cpp

@@ -1260,7 +1260,7 @@ void SkCanvas::drawSprite(const SkBitmap& bitmap, int x, int y,

SkIPoint offset = SkIPoint::Make(0, 0);

SkMatrix matrix = *iter.fMatrix;

matrix.postTranslate(SkIntToScalar(-pos.x()), SkIntToScalar(-pos.y()));

- SkIRect clipBounds = SkIRect::MakeWH(bitmap.width(), bitmap.height());

+ SkIRect clipBounds = bitmap.bounds();

reed1 2014/10/24 18:42:35 nit: const SkIRect ... ?

hal.canary 2014/10/24 19:04:10 Done.

SkAutoTUnref<SkImageFilter::Cache> cache(iter.fDevice->getImageFilterCache());

SkImageFilter::Context ctx(matrix, clipBounds, cache.get());

if (filter->filterImage(&proxy, bitmap, ctx, &dst, &offset)) {

« include/core/SkBitmap.h ('K') | « include/core/SkImageInfo.h ('k') | src/lazy/SkCachingPixelRef.cpp » ('j') | no next file with comments »