Add `SkIRect bounds()` convenience method to SkImageInfo and SkBitmap.

Add `SkIRect bounds()` convenience method to SkImageInfo and SkBitmap.

Committed: https://skia.googlesource.com/skia/+/f622a6c8fd176acf9944de8df00d7f0bb56b67d3

[hal.canary, 2014-10-23 14:21:16]

halcanary@google.com changed reviewers:
+ reed@google.com

[hal.canary, 2014-10-23 14:21:16]

PTAL
priority: low

[reed1, 2014-10-23 14:39:45]

https://codereview.chromium.org/646213003/diff/1/include/core/SkBitmap.h
File include/core/SkBitmap.h (right):

https://codereview.chromium.org/646213003/diff/1/include/core/SkBitmap.h#newc...
include/core/SkBitmap.h:86: SkIRect shape() const { return fInfo.shape(); }
We already have getBounds(SkIRect*). I'm fine if we want a variant that returns
the rect, but I don't see the value of introducing a new label like "shape".

https://codereview.chromium.org/646213003/diff/1/include/core/SkImageInfo.h
File include/core/SkImageInfo.h (right):

https://codereview.chromium.org/646213003/diff/1/include/core/SkImageInfo.h#n...
include/core/SkImageInfo.h:211: SkIRect shape() const { return
SkIRect::MakeWH(fWidth, fHeight); }
please call this bounds instead of shape.

[tfarina, 2014-10-23 15:00:57]

https://codereview.chromium.org/646213003/diff/1/include/core/SkImageInfo.h
File include/core/SkImageInfo.h (right):

https://codereview.chromium.org/646213003/diff/1/include/core/SkImageInfo.h#n...
include/core/SkImageInfo.h:13: #include "SkRect.h"
nit-picking: could you keep it sorted?

[hal.canary, 2014-10-24 18:23:31]

https://codereview.chromium.org/646213003/diff/1/include/core/SkBitmap.h
File include/core/SkBitmap.h (right):

https://codereview.chromium.org/646213003/diff/1/include/core/SkBitmap.h#newc...
include/core/SkBitmap.h:86: SkIRect shape() const { return fInfo.shape(); }
On 2014/10/23 14:39:44, reed1 wrote:
> We already have getBounds(SkIRect*). I'm fine if we want a variant that
returns
> the rect, but I don't see the value of introducing a new label like "shape".

Acknowledged.

https://codereview.chromium.org/646213003/diff/1/include/core/SkImageInfo.h
File include/core/SkImageInfo.h (right):

https://codereview.chromium.org/646213003/diff/1/include/core/SkImageInfo.h#n...
include/core/SkImageInfo.h:13: #include "SkRect.h"
On 2014/10/23 15:00:57, tfarina wrote:
> nit-picking: could you keep it sorted?

Done.

https://codereview.chromium.org/646213003/diff/1/include/core/SkImageInfo.h#n...
include/core/SkImageInfo.h:211: SkIRect shape() const { return
SkIRect::MakeWH(fWidth, fHeight); }
On 2014/10/23 14:39:44, reed1 wrote:
> please call this bounds instead of shape.

Done.

[reed1, 2014-10-24 18:42:35]

lgtm w/ nits

https://codereview.chromium.org/646213003/diff/40001/include/core/SkBitmap.h
File include/core/SkBitmap.h (right):

https://codereview.chromium.org/646213003/diff/40001/include/core/SkBitmap.h#...
include/core/SkBitmap.h:86: SkIRect bounds() const { return fInfo.bounds(); }
nit: lets move these next to the existing getBounds(), or move getBounds() here,
so they are visually grouped together.

https://codereview.chromium.org/646213003/diff/40001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/646213003/diff/40001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:1263: SkIRect clipBounds = bitmap.bounds();
nit: const SkIRect ... ?

[hal.canary, 2014-10-24 19:04:10]

https://codereview.chromium.org/646213003/diff/40001/include/core/SkBitmap.h
File include/core/SkBitmap.h (right):

https://codereview.chromium.org/646213003/diff/40001/include/core/SkBitmap.h#...
include/core/SkBitmap.h:86: SkIRect bounds() const { return fInfo.bounds(); }
On 2014/10/24 18:42:35, reed1 wrote:
> nit: lets move these next to the existing getBounds(), or move getBounds()
here,
> so they are visually grouped together.

Done.

https://codereview.chromium.org/646213003/diff/40001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/646213003/diff/40001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:1263: SkIRect clipBounds = bitmap.bounds();
On 2014/10/24 18:42:35, reed1 wrote:
> nit: const SkIRect ... ?

Done.

[hal.canary, 2014-10-24 19:04:17]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-10-24 19:05:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646213003/60001

[commit-bot: I haz the power, 2014-10-24 19:55:03]

Committed patchset #4 (id:60001) as f622a6c8fd176acf9944de8df00d7f0bb56b67d3