Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: tools/picture_utils.h

Issue 646213002: Eliminate one copy of replace_char() function. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: bad... Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/picture_utils.h
diff --git a/tools/picture_utils.h b/tools/picture_utils.h
index a5fcf7c96898cdcc178849025d2d98a4f5481639..4966bfa627df89c581d5260e22b270707d5b61cc 100644
--- a/tools/picture_utils.h
+++ b/tools/picture_utils.h
@@ -20,15 +20,6 @@ namespace sk_tools {
// not be on the GPU.
void force_all_opaque(const SkBitmap& bitmap);
- /**
- * Replaces all instances of oldChar with newChar in str.
- *
- * TODO: This function appears here and in skimage_main.cpp ;
- * we should add the implementation to src/core/SkString.cpp, write tests for it,
- * and remove it from elsewhere.
- */
- void replace_char(SkString* str, const char oldChar, const char newChar);
-
// Returns true if the string ends with %
bool is_percentage(const char* const string);
« tests/StringTest.cpp ('K') | « tools/PictureRenderer.cpp ('k') | tools/picture_utils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698