Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: tools/picture_utils.h

Issue 646213002: Eliminate one copy of replace_char() function. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: bad... Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef picture_utils_DEFINED 8 #ifndef picture_utils_DEFINED
9 #define picture_utils_DEFINED 9 #define picture_utils_DEFINED
10 10
11 class SkBitmap; 11 class SkBitmap;
12 class SkString; 12 class SkString;
13 13
14 namespace sk_tools { 14 namespace sk_tools {
15 // since PNG insists on unpremultiplying our alpha, we take no precision 15 // since PNG insists on unpremultiplying our alpha, we take no precision
16 // chances and force all pixels to be 100% opaque, otherwise on compare we 16 // chances and force all pixels to be 100% opaque, otherwise on compare we
17 // may not get a perfect match. 17 // may not get a perfect match.
18 // 18 //
19 // This expects a bitmap with a config type of 8888 and for the pixels to 19 // This expects a bitmap with a config type of 8888 and for the pixels to
20 // not be on the GPU. 20 // not be on the GPU.
21 void force_all_opaque(const SkBitmap& bitmap); 21 void force_all_opaque(const SkBitmap& bitmap);
22 22
23 /**
24 * Replaces all instances of oldChar with newChar in str.
25 *
26 * TODO: This function appears here and in skimage_main.cpp ;
27 * we should add the implementation to src/core/SkString.cpp, write tests fo r it,
28 * and remove it from elsewhere.
29 */
30 void replace_char(SkString* str, const char oldChar, const char newChar);
31
32 // Returns true if the string ends with % 23 // Returns true if the string ends with %
33 bool is_percentage(const char* const string); 24 bool is_percentage(const char* const string);
34 25
35 // Prepares the bitmap so that it can be written. 26 // Prepares the bitmap so that it can be written.
36 // 27 //
37 // Specifically, it configures the bitmap, allocates pixels and then 28 // Specifically, it configures the bitmap, allocates pixels and then
38 // erases the pixels to transparent black. 29 // erases the pixels to transparent black.
39 void setup_bitmap(SkBitmap* bitmap, int width, int height); 30 void setup_bitmap(SkBitmap* bitmap, int width, int height);
40 31
41 /** 32 /**
42 * Write a bitmap file to disk. 33 * Write a bitmap file to disk.
43 * 34 *
44 * @param bm the bitmap to record 35 * @param bm the bitmap to record
45 * @param dirPath directory within which to write the image file 36 * @param dirPath directory within which to write the image file
46 * @param subdirOrNull subdirectory within dirPath, or NULL to just write in to dirPath 37 * @param subdirOrNull subdirectory within dirPath, or NULL to just write in to dirPath
47 * @param baseName last part of the filename 38 * @param baseName last part of the filename
48 * 39 *
49 * @return true if written out successfully 40 * @return true if written out successfully
50 */ 41 */
51 bool write_bitmap_to_disk(const SkBitmap& bm, const SkString& dirPath, 42 bool write_bitmap_to_disk(const SkBitmap& bm, const SkString& dirPath,
52 const char *subdirOrNull, const SkString& baseName ); 43 const char *subdirOrNull, const SkString& baseName );
53 44
54 } // namespace sk_tools 45 } // namespace sk_tools
55 46
56 #endif // picture_utils_DEFINED 47 #endif // picture_utils_DEFINED
OLDNEW
« tests/StringTest.cpp ('K') | « tools/PictureRenderer.cpp ('k') | tools/picture_utils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698