Eliminate one copy of replace_char() function.

tests/StringTest.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <stdarg.h>
 #include <stdio.h>
 #include "SkString.h"
@@ skipping 165 matching lines @@
 
     char buffer [40];
     memset(buffer, 'a', 40);
     REPORTER_ASSERT(reporter, buffer[18] == 'a');
     REPORTER_ASSERT(reporter, buffer[19] == 'a');
     REPORTER_ASSERT(reporter, buffer[20] == 'a');
     printfAnalog(buffer, 20, "%30d", 0);
     REPORTER_ASSERT(reporter, buffer[18] == ' ');
     REPORTER_ASSERT(reporter, buffer[19] == 0);
     REPORTER_ASSERT(reporter, buffer[20] == 'a');
+}
 
+DEF_TEST(String_Replace, r) {
+    SkString str("skia_2d");
+    str.replace('_', '-');
+    REPORTER_ASSERT(r, str.equals("skia-2d"));
+
+    str.set("meat");
+    str.replace('a', 'e');
+    REPORTER_ASSERT(r, str.equals("meet"));
+
+    str.set("hello, world!");
+    str.replace('h', 'h');
+    REPORTER_ASSERT(r, str.equals("hello, world!"));
+    str.replace('x', 'x');
+    REPORTER_ASSERT(r, str.equals("hello, world!"));
+    str.replace('o', 'u');
+    REPORTER_ASSERT(r, str.equals("hellu, wurld!"));
+    str.replace('x', 'u');
+    REPORTER_ASSERT(r, str.equals("hellu, wurld!"));
+    str.replace('x', 'y');
+    REPORTER_ASSERT(r, str.equals("hellu, wurld!"));
+
+    str.set("");
+    str.replace('a', 'b');
+    REPORTER_ASSERT(r, str.equals(""));
+
+    str.set("\xed\x95\x9c\xea\xb5\xad\xec\x96\xb4");

[tfarina, 2014/11/12 01:41:34]

Could you suggest another string to test that SkUTF8_FromUnichar would like?

[reed1, 2014/11/12 14:11:25]

Why not build the string with a set of known Unichars (of any size). Internally
SkString will convert those to utf8 if you call str.appendUnichar()

+    //SkString hangul2("\xb4\x95\x9c\xea\xb5\xad\xec\x96\xb4");
+    str.replace('\xed', '\xb4');
+    //REPORTER_ASSERT(r, hangul == hangul2);
 }
 
 DEF_TEST(String_SkStrSplit, r) {
     SkTArray<SkString> results;
 
     SkStrSplit("a-_b_c-dee--f-_-_-g-", "-_", &results);
     REPORTER_ASSERT(r, results.count() == 6);
     REPORTER_ASSERT(r, results[0].equals("a"));
     REPORTER_ASSERT(r, results[1].equals("b"));
     REPORTER_ASSERT(r, results[2].equals("c"));
     REPORTER_ASSERT(r, results[3].equals("dee"));
     REPORTER_ASSERT(r, results[4].equals("f"));
     REPORTER_ASSERT(r, results[5].equals("g"));
 }