Eliminate one copy of replace_char() function.

src/core/SkString.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkString.h"
@@ skipping 610 matching lines @@
             size_t tail = size - (offset + length);
             if (tail) {
                 memcpy(dst + offset, src + (offset + length), tail);
             }
             SkASSERT(dst[tmp.size()] == 0);
             this->swap(tmp);
         }
     }
 }
 
+void SkString::replace(SkUnichar oldChar, SkUnichar newChar) {
+    char buffer[kMaxBytesInUTF8Sequence];
+    size_t len = SkUTF8_FromUnichar(oldChar, buffer);

[tfarina, 2014/11/12 01:41:34]

Mike, could you help me here?

I'm getting the following error when I run the tests:

../../src/core/SkUtils.cpp:268: failed assertion "false && "bad unichar""
Segmentation fault (core dumped)

+
+    if (len) {
+    }
+
+    for (size_t i = 0; i < size(); ++i) {
+        if (oldChar == this->operator[](i)) {
+            this->operator[](i) = newChar;
+        }
+    }
+}
+
 void SkString::swap(SkString& other) {
     this->validate();
     other.validate();
 
     SkTSwap<Rec*>(fRec, other.fRec);
 #ifdef SK_DEBUG
     SkTSwap<const char*>(fStr, other.fStr);
 #endif
 }
 
@@ skipping 15 matching lines @@
         const size_t len = strcspn(str, delimiters);
         out->push_back().set(str, len);
         str += len;
         // Skip any delimiters.
         str += strspn(str, delimiters);
     }
 }
 
 #undef VSNPRINTF
 #undef SNPRINTF