Don't convert invalidations to a FloatRect.

Don't convert invalidations to a FloatRect.

We just turn it back into an IntRect on the cc side.

Depends on: https://codereview.chromium.org/647253002/
Depends on: https://codereview.chromium.org/655863002/

R=enne
BUG=342848
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183693

[enne (OOO), 2014-10-13 21:34:48]

lgtm

[enne (OOO), 2014-10-13 21:34:57]

https://codereview.chromium.org/646133002/diff/1/Source/platform/graphics/Gra...
File Source/platform/graphics/GraphicsLayer.h (right):

https://codereview.chromium.org/646133002/diff/1/Source/platform/graphics/Gra...
Source/platform/graphics/GraphicsLayer.h:185: // Mark the given rect (in layer
coords) as needing dispay. Never goes deep.
dispay, eh?

[danakj, 2014-10-14 16:35:50]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-10-14 16:36:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646133002/90001

[commit-bot: I haz the power, 2014-10-14 16:42:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 16:42:44]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[danakj, 2014-10-14 16:44:53]

danakj@chromium.org changed reviewers:
+ mkwst@chromium.org

[danakj, 2014-10-14 16:44:53]

I need a public/ owner for removing this method. +mkwst

[danakj, 2014-10-14 16:55:18]

On 2014/10/14 16:44:53, danakj wrote:
> I need a public/ owner for removing this method. +mkwst

Sorry long weekend sleepiness. Rather, for adding a WebRect version.

[danakj, 2014-10-14 16:56:35]

danakj@chromium.org changed reviewers:
+ junov@chromium.org

[danakj, 2014-10-14 16:56:35]

enne: I had to change the popup impl (which was just casting to floatrect), and
the Canvas2dLayerBridge (which actually seemed to have float rect data and i
took the enclosingIntRect) +junov

[Justin Novosad, 2014-10-14 17:06:58]

lgtm for Canvas2DLayerBridge

[enne (OOO), 2014-10-14 17:12:32]

lgtm still

[Rick Byers, 2014-10-14 17:52:05]

rbyers@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2014-10-14 17:52:06]

public/ LGTM with nit

https://codereview.chromium.org/646133002/diff/150001/public/platform/WebLayer.h
File public/platform/WebLayer.h (right):

https://codereview.chromium.org/646133002/diff/150001/public/platform/WebLaye...
public/platform/WebLayer.h:50: struct WebFloatRect;
nit: looks like you can remove this forward declaration now too

[danakj, 2014-10-14 17:52:42]

On 2014/10/14 17:52:06, Rick Byers wrote:
> public/ LGTM with nit
> 
>
https://codereview.chromium.org/646133002/diff/150001/public/platform/WebLayer.h
> File public/platform/WebLayer.h (right):
> 
>
https://codereview.chromium.org/646133002/diff/150001/public/platform/WebLaye...
> public/platform/WebLayer.h:50: struct WebFloatRect;
> nit: looks like you can remove this forward declaration now too

Thanks, done.

[danakj, 2014-10-14 17:53:39]

danakj@chromium.org changed reviewers:
- mkwst@chromium.org

[aelias_OOO_until_Jul13, 2014-10-14 17:54:52]

aelias@chromium.org changed reviewers:
+ aelias@chromium.org, mkwst@chromium.org

[aelias_OOO_until_Jul13, 2014-10-14 17:54:53]

Source/web lgtm

[danakj, 2014-10-14 18:14:38]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-10-14 18:15:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646133002/170001

[commit-bot: I haz the power, 2014-10-14 18:54:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 18:54:38]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[danakj, 2014-10-14 19:04:26]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-10-14 19:05:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646133002/170001

[commit-bot: I haz the power, 2014-10-14 19:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 19:09:12]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[danakj, 2014-10-14 19:09:56]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-10-14 19:10:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646133002/170001

[commit-bot: I haz the power, 2014-10-14 19:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 19:13:51]

Try jobs failed on following builders:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[danakj, 2014-10-14 19:22:28]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-10-14 19:23:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646133002/170001

[commit-bot: I haz the power, 2014-10-14 19:34:55]

Committed patchset #6 (id:170001) as 183693