400 permissions on testing_rsa file.

400 permissions on testing_rsa file.

BUG=421617
TEST=manual

Committed: https://crrev.com/9909321a8b8c722b05ee477ffaade23f9a244644
Cr-Commit-Position: refs/heads/master@{#299247}

[achuithb, 2014-10-10 23:25:23]

achuith@chromium.org changed reviewers:
+ ihf@chromium.org, tbarzic@chromium.org

[achuithb, 2014-10-10 23:25:24]

Toni, Ilya please take a look.

[ilja, 2014-10-10 23:35:10]

https://codereview.chromium.org/646103003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/platform/cros_interface.py (right):

https://codereview.chromium.org/646103003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/cros_interface.py:97:
os.chmod(self._ssh_identity, stat.S_IREAD)
I think you want stat.S_IREAD | stat.S_IWRITE as you are setting currently
setting 400 but your commit message says 600 (and the file is checked in as
600), but in any case I think this should fix the failing tests.

[achuithb, 2014-10-10 23:47:31]

https://codereview.chromium.org/646103003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/platform/cros_interface.py (right):

https://codereview.chromium.org/646103003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/cros_interface.py:97:
os.chmod(self._ssh_identity, stat.S_IREAD)
On 2014/10/10 23:35:10, ilja wrote:
> I think you want stat.S_IREAD | stat.S_IWRITE as you are setting currently
> setting 400 but your commit message says 600 (and the file is checked in as
> 600), but in any case I think this should fix the failing tests.

I've changed the description to say 400. Doesn't seem to be any point in making
this file writeable.

[ilja, 2014-10-10 23:50:17]

lgtm

[achuithb, 2014-10-10 23:50:54]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2014-10-10 23:51:16]

On 2014/10/10 23:50:17, ilja wrote:
> lgtm

Toni - believe I still need an lgtm from you as Ilya is not a committer.

[commit-bot: I haz the power, 2014-10-10 23:52:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646103003/1

[commit-bot: I haz the power, 2014-10-10 23:52:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-10 23:52:34]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tbarzic, 2014-10-10 23:54:39]

On 2014/10/10 23:52:34, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

lgtm

[achuithb, 2014-10-11 18:02:55]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-10-11 18:03:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646103003/1

[commit-bot: I haz the power, 2014-10-11 19:15:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-11 19:16:27]

Patchset 1 (id:??) landed as
https://crrev.com/9909321a8b8c722b05ee477ffaade23f9a244644
Cr-Commit-Position: refs/heads/master@{#299247}