Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: device/serial/data_stream.mojom

Issue 646063003: Change data pipe wrappers used by SerialConnection to use message pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix win x64 compile Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/data_source_sender.cc ('k') | device/serial/data_stream_serialization.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/data_stream.mojom
diff --git a/device/serial/data_stream.mojom b/device/serial/data_stream.mojom
index 689b38148411ede1b7ca63c39c3a2f47a841027b..8968d7ac75db43077412edd02906211709d3ca26 100644
--- a/device/serial/data_stream.mojom
+++ b/device/serial/data_stream.mojom
@@ -6,30 +6,39 @@ module device.serial {
[Client=DataSourceClient]
interface DataSource {
- // Initializes this DataSource with a data pipe handle to use for data
- // transmission.
- Init(handle<data_pipe_producer> producer_handle);
+ // Initializes this DataSource with the amount of data its client will
+ // buffer.
+ Init(uint32 buffer_size);
// Resumes sending data after it has been stopped due to an error.
Resume();
+
+ // Reports that |bytes_sent| bytes have been successfully passed to the
+ // client.
+ ReportBytesReceived(uint32 bytes_sent);
};
interface DataSourceClient {
- // Invoked to report |error| from the DataSource, at |error_location| bytes
- // into the data stream. No further bytes beyond |error_location| will be
+ // Invoked to report |error| from the DataSource. No further bytes will be
// transmitted from the DataSource until Resume() is called.
- OnError(uint32 error_location, int32 error);
+ OnError(int32 error);
+
+ // Invoked to transmit data from the DataSource.
+ OnData(array<uint8> data);
};
[Client=DataSinkClient]
interface DataSink {
- // Initializes this DataSink with a data pipe handle to use for data
- // transmission.
- Init(handle<data_pipe_consumer> consumer_handle);
+ // Initializes this DataSink with the amount of data it is expected to
+ // buffer.
+ Init(uint32 buffer_size);
// Requests the cancellation of any data that has been written to the pipe,
// but has not yet been sent to the sink.
Cancel(int32 error);
+
+ // Invoked to pass |data| to the sink.
+ OnData(array<uint8> data);
};
interface DataSinkClient {
@@ -37,10 +46,10 @@ interface DataSinkClient {
ReportBytesSent(uint32 bytes_sent);
// Reports that the sink has received |bytes_sent| bytes of data (possibly 0)
- // and encountered an error: |error|. The client should respond with
- // |bytes_to_flush|, the number of bytes enqueued in the data pipe but not yet
- // acked so the correct number of bytes can be flushed from the pipe.
- ReportBytesSentAndError(uint32 bytes_sent, int32 error) => (uint32 bytes_to_flush);
+ // and encountered an error: |error|. Any OnData messages received by the
+ // DataSink before the response will be discarded. The client should respond
+ // when it is ready to resume sending data.
+ ReportBytesSentAndError(uint32 bytes_sent, int32 error) => ();
};
}
« no previous file with comments | « device/serial/data_source_sender.cc ('k') | device/serial/data_stream_serialization.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698