Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: extensions/renderer/api/serial/data_receiver_unittest.cc

Issue 646063003: Change data pipe wrappers used by SerialConnection to use message pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api/serial/data_receiver_unittest.cc
diff --git a/extensions/renderer/api/serial/data_receiver_unittest.cc b/extensions/renderer/api/serial/data_receiver_unittest.cc
index 2415e00568e465e996ac402bb66135e940114c4b..09de207df3bf0ca1d70c66cb59124e920866856d 100644
--- a/extensions/renderer/api/serial/data_receiver_unittest.cc
+++ b/extensions/renderer/api/serial/data_receiver_unittest.cc
@@ -63,11 +63,6 @@ class DataReceiverTest : public ApiTestBase {
error = error_to_send_.front();
error_to_send_.pop();
}
- if (error == 2) {
- sender_->ShutDown();
- sender_ = NULL;
- return;
- }
DCHECK(buffer->GetSize() >= static_cast<uint32_t>(data.size()));
memcpy(buffer->GetData(), data.c_str(), data.size());
if (error)
@@ -136,9 +131,4 @@ TEST_F(DataReceiverTest, SerializeAfterClose) {
RunTest("data_receiver_unittest.js", "testSerializeAfterClose");
}
-TEST_F(DataReceiverTest, SourceShutdown) {
- error_to_send_.push(2);
- RunTest("data_receiver_unittest.js", "testSourceShutdown");
-}
-
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698