Change data pipe wrappers used by SerialConnection to use message pipe.

device/serial/serial_connection_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/string_piece.h"
@@ skipping 251 matching lines @@
 TEST_F(SerialConnectionTest, Flush) {
   ASSERT_EQ(0, io_handler_->flushes());
   connection_->Flush(base::Bind(&SerialConnectionTest::StoreSuccess,
                                 base::Unretained(this),
                                 EVENT_FLUSHED));
   WaitForEvent(EVENT_FLUSHED);
   ASSERT_TRUE(success_);
   EXPECT_EQ(1, io_handler_->flushes());
 }
 
-TEST_F(SerialConnectionTest, Disconnect) {
+TEST_F(SerialConnectionTest, DisconnectWithSend) {
   connection_.reset();
   io_handler_->set_send_callback(base::Bind(base::DoNothing));
   ASSERT_NO_FATAL_FAILURE(Send("data"));
   WaitForEvent(EVENT_SEND_ERROR);
   EXPECT_EQ(serial::SEND_ERROR_DISCONNECTED, send_error_);
   EXPECT_EQ(0, bytes_sent_);
+  EXPECT_TRUE(io_handler_->HasOneRef());

[raymes, 2014/10/17 02:11:10]

Hmm, what does this check?

[Sam McNally, 2014/10/20 05:12:59]

This checks that the connection object has actually been deleted or at least
isn't holding onto |io_handler_|.

+}
+
+TEST_F(SerialConnectionTest, DisconnectWithReceive) {
+  connection_.reset();

[raymes, 2014/10/17 02:11:10]

And how come this is needed now?

[Sam McNally, 2014/10/20 05:12:59]

Timing is different when data goes over the control pipe.

   ASSERT_NO_FATAL_FAILURE(Receive());
   WaitForEvent(EVENT_RECEIVE_ERROR);
   EXPECT_EQ(serial::RECEIVE_ERROR_DISCONNECTED, receive_error_);
   EXPECT_EQ("", data_received_);
   EXPECT_TRUE(io_handler_->HasOneRef());
 }
 
 TEST_F(SerialConnectionTest, Echo) {
   ASSERT_NO_FATAL_FAILURE(Send("data"));
   WaitForEvent(EVENT_DATA_SENT);
@@ skipping 29 matching lines @@
   WaitForEvent(EVENT_DATA_SENT);
   EXPECT_EQ(serial::SEND_ERROR_NONE, send_error_);
   EXPECT_EQ(4, bytes_sent_);
   ASSERT_NO_FATAL_FAILURE(Receive());
   WaitForEvent(EVENT_DATA_RECEIVED);
   EXPECT_EQ("data", data_received_);
   EXPECT_EQ(serial::RECEIVE_ERROR_NONE, receive_error_);
 }
 
 }  // namespace device