Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 646033009: Add openCV dependency to install-build-deps.sh (Closed)

Created:
6 years, 1 month ago by mthiesse
Modified:
6 years, 1 month ago
CC:
chromium-reviews, M-A Ruel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add openCV dependency to install-build-deps.sh Context: https://codereview.chromium.org/660893002/ BUG=424345 Committed: https://crrev.com/776da3a896a263d1edd906e6d29e4faad63c9d73 Cr-Commit-Position: refs/heads/master@{#301404}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
mthiesse
PTAL. Despite the OWNERS for the build directory being *, I believe maruel@ is the ...
6 years, 1 month ago (2014-10-23 17:07:36 UTC) #2
M-A Ruel
You actually want Ryan and Pawel.
6 years, 1 month ago (2014-10-23 17:08:52 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/646033009/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/646033009/diff/1/build/install-build-deps.sh#newcode97 build/install-build-deps.sh:97: dev_list="apache2.2-bin bison cdbs curl dpkg-dev elfutils devscripts fakeroot Why ...
6 years, 1 month ago (2014-10-27 11:52:53 UTC) #5
mthiesse
https://codereview.chromium.org/646033009/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/646033009/diff/1/build/install-build-deps.sh#newcode97 build/install-build-deps.sh:97: dev_list="apache2.2-bin bison cdbs curl dpkg-dev elfutils devscripts fakeroot On ...
6 years, 1 month ago (2014-10-27 14:15:34 UTC) #6
Paweł Hajdan Jr.
LGTM
6 years, 1 month ago (2014-10-27 15:12:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646033009/20001
6 years, 1 month ago (2014-10-27 18:16:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 19:29:09 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:29:49 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/776da3a896a263d1edd906e6d29e4faad63c9d73
Cr-Commit-Position: refs/heads/master@{#301404}

Powered by Google App Engine
This is Rietveld 408576698