GN: Capture and print stderr from exec_script

GN: Capture and print stderr from exec_script

This moves ExecProcess to exec_process.h/cc and adds capturing
of stderr on linux.

Adds unittests for ExecProcess.

Windows is not supported.

Committed: https://crrev.com/5579301b2f2c78d737c07d832f3e4b57f167729d
Cr-Commit-Position: refs/heads/master@{#299951}

[cjhopman, 2014-10-13 18:07:51]

cjhopman@chromium.org changed reviewers:
+ brettw@chromium.org

[cjhopman, 2014-10-13 18:07:55]

brettw: *

https://codereview.chromium.org/646013003/diff/250001/tools/gn/exec_process_u...
File tools/gn/exec_process_unittest.cc (right):

https://codereview.chromium.org/646013003/diff/250001/tools/gn/exec_process_u...
tools/gn/exec_process_unittest.cc:70: TEST(ExecProcessTest,
TestStdoutAndStderrOutput) {
Windows should fail these two tests, so they still need to be disabled there.

[cjhopman, 2014-10-13 18:18:49]

https://codereview.chromium.org/646013003/diff/340001/tools/gn/exec_process.cc
File tools/gn/exec_process.cc (right):

https://codereview.chromium.org/646013003/diff/340001/tools/gn/exec_process.c...
tools/gn/exec_process.cc:1: // Copyright (c) 2013 The Chromium Authors. All
rights reserved.
This patch set contains exec_process copied unchanged from
tools/gn/function_exec_script.cc to make it easier to see what this change
actually changes. Just look at the diff against this.

[brettw, 2014-10-14 17:27:56]

lgtm

https://codereview.chromium.org/646013003/diff/440001/tools/gn/exec_process.cc
File tools/gn/exec_process.cc (right):

https://codereview.chromium.org/646013003/diff/440001/tools/gn/exec_process.c...
tools/gn/exec_process.cc:140: 
Nit: only one blank

https://codereview.chromium.org/646013003/diff/440001/tools/gn/exec_process.c...
tools/gn/exec_process.cc:168: return false;
Indent (also remove {})

https://codereview.chromium.org/646013003/diff/440001/tools/gn/exec_process.c...
tools/gn/exec_process.cc:226: FD_SET(out_read.get(), &read_fds);
select() sure is yucky!

https://codereview.chromium.org/646013003/diff/440001/tools/gn/exec_process.c...
tools/gn/exec_process.cc:236: if (FD_ISSET(out_read.get(), &read_fds)) {
No {} for consistency.

[cjhopman, 2014-10-16 18:24:19]

The CQ bit was checked by cjhopman@chromium.org

[cjhopman, 2014-10-16 18:25:05]

https://codereview.chromium.org/646013003/diff/440001/tools/gn/exec_process.cc
File tools/gn/exec_process.cc (right):

https://codereview.chromium.org/646013003/diff/440001/tools/gn/exec_process.c...
tools/gn/exec_process.cc:140: 
On 2014/10/14 17:27:56, brettw wrote:
> Nit: only one blank

Done.

https://codereview.chromium.org/646013003/diff/440001/tools/gn/exec_process.c...
tools/gn/exec_process.cc:168: return false;
On 2014/10/14 17:27:56, brettw wrote:
> Indent (also remove {})

Done.

https://codereview.chromium.org/646013003/diff/440001/tools/gn/exec_process.c...
tools/gn/exec_process.cc:236: if (FD_ISSET(out_read.get(), &read_fds)) {
On 2014/10/14 17:27:56, brettw wrote:
> No {} for consistency.

Done.

[commit-bot: I haz the power, 2014-10-16 18:25:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646013003/520001

[commit-bot: I haz the power, 2014-10-16 19:19:53]

Committed patchset #8 (id:520001)

[commit-bot: I haz the power, 2014-10-16 19:23:18]

Patchset 8 (id:??) landed as
https://crrev.com/5579301b2f2c78d737c07d832f3e4b57f167729d
Cr-Commit-Position: refs/heads/master@{#299951}