Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 646013002: Steer clear of g++ scoping bug in range-based for loop. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Steer clear of g++ scoping bug in range-based for loop. With g++, the scope of the per-element local variable currently (g++-4.8.1) and incorrectly extends over the generator/range expression also, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54430 Rename the loop variable in CachedMatchedPropertiesHashTraits's traceInCollection() to avoid running into the bug. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/css/resolver/MatchedPropertiesCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
Please take a look. Unbreaks Oilpan ToT w/ g++.
6 years, 2 months ago (2014-10-10 20:28:50 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-11 01:02:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646013002/1
6 years, 2 months ago (2014-10-11 05:25:45 UTC) #5
Mike West
LGTM 2, though Kentaro-san was _way_ faster than I. :)
6 years, 2 months ago (2014-10-11 07:07:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31307)
6 years, 2 months ago (2014-10-11 10:03:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646013002/1
6 years, 2 months ago (2014-10-11 13:50:57 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 14:26:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183574

Powered by Google App Engine
This is Rietveld 408576698