Issue 646010: Change the implementation of lastIndexOf method of String. Convert the string...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 646010: Change the implementation of lastIndexOf method of String. Convert the string... (Closed)

Created:
10 years, 10 months ago by Oleg Eterevsky

Modified:
9 years, 5 months ago

Reviewers:
Vitaly Repeshko, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change the implementation of lastIndexOf method of String. Convert the strings in question to Vector<char> or Vector<uc16> and execute simple search algorithm on them. The difference in speed on 500k character string is about 10x.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 3

Patch Set 6 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -20 lines)			Patch
	M	src/runtime.cc	View	1 2 3 4 5	3 chunks	+76 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 10 months ago (2010-02-19 16:53:08 UTC) #2

LGTM.

Please fix a few nits and I'll land.


Thanks,
Vitaly

http://codereview.chromium.org/646010/diff/3004/3005
File src/runtime.cc (right):

http://codereview.chromium.org/646010/diff/3004/3005#newcode2475
src/runtime.cc:2475: int idx) {
Please add asserts about lengths and idx.

http://codereview.chromium.org/646010/diff/3004/3005#newcode2476
src/runtime.cc:2476: if (sizeof(pchar) > 1 && sizeof(schar) == 1) {
(nit) Swap conditions so that sub checks go before pat checks.

http://codereview.chromium.org/646010/diff/3004/3005#newcode4151
src/runtime.cc:4151: CONVERT_DOUBLE_CHECKED(number, args[0]);
Let's put this in a separate change.

Expand Messages | Collapse Messages