Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 6460020: Merge 77608 - 2011-02-03 Victoria Kirst <vrk@google.com>... (Closed)

Created:
9 years, 10 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
eseidel1, commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/648/
Visibility:
Public.

Description

Merge 77608 - 2011-02-03 Victoria Kirst <vrk@google.com>; Reviewed by James Robinson. Replaces float literals with uniform values in shader code so that buggy drivers unable to parse float values in different locales will not produce a pink video. [chromium] Fix pink video bug with gpu-acceleration enabled https://bugs.webkit.org/show_bug.cgi?id=53568 * platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::drawYUV): * platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::signAdjLocation): TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -799 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +0 lines, -795 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp View 6 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
9 years, 10 months ago (2011-02-09 02:10:06 UTC) #1
eseidel1
9 years, 10 months ago (2011-02-09 02:34:53 UTC) #2
Um... ?
On Feb 8, 2011 6:10 PM, <scherkus@chromium.org> wrote:
> Reviewers: commit-queue_webkit.org,
>
> Description:
> Merge 77608 - 2011-02-03 Victoria Kirst <vrk@google.com>
>
> Reviewed by James Robinson.
>
> Replaces float literals with uniform values in shader code
> so that buggy drivers unable to parse float values in different
> locales will not produce a pink video.
>
> [chromium] Fix pink video bug with gpu-acceleration enabled
> https://bugs.webkit.org/show_bug.cgi?id=53568
>
> * platform/graphics/chromium/VideoLayerChromium.cpp:
> (WebCore::VideoLayerChromium::SharedValues::SharedValues):
> (WebCore::VideoLayerChromium::drawYUV):
> * platform/graphics/chromium/VideoLayerChromium.h:
> (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):
>
> TBR=commit-queue@webkit.org
>
> Please review this at http://codereview.chromium.org/6460020/
>
> SVN Base: http://svn.webkit.org/repository/webkit/branches/chromium/648/
>
> Affected files:
> M Source/WebCore/ChangeLog
> M Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h
> M Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp
>
>

Powered by Google App Engine
This is Rietveld 408576698