Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 645993004: Oilpan: fix build after r183972. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r183972. With Oilpan, ScriptWrappable has no destructor, so we need to provide a virtual destructor for RefCounted<DOMArrayBufferView> instead. TBR=oilpan-reviews,haraken BUG=235436 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/dom/DOMArrayBufferView.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sof
Please take a look.
6 years, 2 months ago (2014-10-20 12:06:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645993004/1
6 years, 2 months ago (2014-10-20 12:18:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183976
6 years, 2 months ago (2014-10-20 12:19:35 UTC) #4
Yuki
On 2014/10/20 12:19:35, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 2 months ago (2014-10-20 12:24:10 UTC) #5
sof
On 2014/10/20 12:24:10, Yuki wrote: > On 2014/10/20 12:19:35, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-10-20 12:29:24 UTC) #6
haraken
6 years, 2 months ago (2014-10-20 13:53:04 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698