Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 645993002: Fix LCD text handling for SVG filters. (Closed)

Created:
6 years, 2 months ago by Stephen White
Modified:
6 years, 2 months ago
Reviewers:
f(malita)
CC:
blink-reviews, blink-reviews-rendering, Rik, jbroman, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, mkwst+moarreviews_chromium.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rune+blink, hendrikw
Project:
blink
Visibility:
Public.

Description

Fix LCD text handling for SVG filters. Turn off LCD (subpixel AA) text while recording the DisplayList used for image filters, since we don't know about the opacity of the destination playback canvas (and using the recording canvas's opacity is wrong). BUG=422176 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183558

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Stephen White
Florin: PTAL. Thanks!
6 years, 2 months ago (2014-10-10 17:57:47 UTC) #2
f(malita)
lgtm Is it possible to write a test for this regression?
6 years, 2 months ago (2014-10-10 20:11:46 UTC) #3
danakj
hendrickw@ could this be your bug?
6 years, 2 months ago (2014-10-10 20:13:53 UTC) #4
Stephen White
On 2014/10/10 20:11:46, Florin Malita wrote: > lgtm > > Is it possible to write ...
6 years, 2 months ago (2014-10-10 20:19:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645993002/1
6 years, 2 months ago (2014-10-10 20:20:00 UTC) #7
danakj
On 2014/10/10 20:13:53, danakj wrote: > hendrickw@ could this be your bug? Actually nvm this ...
6 years, 2 months ago (2014-10-10 20:20:34 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 21:51:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183558

Powered by Google App Engine
This is Rietveld 408576698