Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Side by Side Diff: cc/resources/one_copy_raster_worker_pool.cc

Issue 645943002: cc: Move GpuMemoryBuffer allocation to worker threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chromium-image-refactor
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/resources/resource_provider.h » ('j') | cc/resources/resource_provider.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/one_copy_raster_worker_pool.h" 5 #include "cc/resources/one_copy_raster_worker_pool.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/debug/trace_event.h" 9 #include "base/debug/trace_event.h"
10 #include "base/debug/trace_event_argument.h" 10 #include "base/debug/trace_event_argument.h"
(...skipping 14 matching lines...) Expand all
25 RasterBufferImpl(ResourceProvider* resource_provider, 25 RasterBufferImpl(ResourceProvider* resource_provider,
26 ResourcePool* resource_pool, 26 ResourcePool* resource_pool,
27 const Resource* resource) 27 const Resource* resource)
28 : resource_provider_(resource_provider), 28 : resource_provider_(resource_provider),
29 resource_pool_(resource_pool), 29 resource_pool_(resource_pool),
30 resource_(resource), 30 resource_(resource),
31 raster_resource_(resource_pool->AcquireResource(resource->size())), 31 raster_resource_(resource_pool->AcquireResource(resource->size())),
32 lock_(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer( 32 lock_(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer(
33 resource_provider_, 33 resource_provider_,
34 raster_resource_->id())), 34 raster_resource_->id())),
35 buffer_(NULL) {} 35 gpu_memory_buffer_(nullptr),
36 buffer_(nullptr) {}
36 37
37 virtual ~RasterBufferImpl() { 38 virtual ~RasterBufferImpl() {
38 // First unlock raster resource. 39 // First unlock raster resource.
39 lock_.reset(); 40 lock_.reset();
40 41
41 // Copy contents of raster resource to |resource_|. 42 // Copy contents of raster resource to |resource_|.
42 resource_provider_->CopyResource(raster_resource_->id(), resource_->id()); 43 if (gpu_memory_buffer_)
44 resource_provider_->CopyResource(raster_resource_->id(), resource_->id());
43 45
44 // Return raster resource to pool so it can be used by another RasterBuffer 46 // Return raster resource to pool so it can be used by another RasterBuffer
45 // instance. 47 // instance.
46 resource_pool_->ReleaseResource(raster_resource_.Pass()); 48 resource_pool_->ReleaseResource(raster_resource_.Pass());
47 } 49 }
48 50
49 // Overridden from RasterBuffer: 51 // Overridden from RasterBuffer:
50 virtual skia::RefPtr<SkCanvas> AcquireSkCanvas() override { 52 virtual skia::RefPtr<SkCanvas> AcquireSkCanvas() override {
51 gfx::GpuMemoryBuffer* gpu_memory_buffer = lock_->gpu_memory_buffer(); 53 gpu_memory_buffer_ = lock_->GetGpuMemoryBuffer();
52 if (!gpu_memory_buffer) 54 if (!gpu_memory_buffer_)
53 return skia::AdoptRef(SkCreateNullCanvas()); 55 return skia::AdoptRef(SkCreateNullCanvas());
54 56
55 buffer_ = gpu_memory_buffer->Map(); 57 buffer_ = gpu_memory_buffer_->Map();
56 RasterWorkerPool::AcquireBitmapForBuffer(&bitmap_, 58 RasterWorkerPool::AcquireBitmapForBuffer(&bitmap_,
57 buffer_, 59 buffer_,
58 resource_->format(), 60 resource_->format(),
59 resource_->size(), 61 resource_->size(),
60 gpu_memory_buffer->GetStride()); 62 gpu_memory_buffer_->GetStride());
61 return skia::AdoptRef(new SkCanvas(bitmap_)); 63 return skia::AdoptRef(new SkCanvas(bitmap_));
62 } 64 }
63 virtual void ReleaseSkCanvas(const skia::RefPtr<SkCanvas>& canvas) override { 65 virtual void ReleaseSkCanvas(const skia::RefPtr<SkCanvas>& canvas) override {
64 gfx::GpuMemoryBuffer* gpu_memory_buffer = lock_->gpu_memory_buffer(); 66 if (!gpu_memory_buffer_)
65 if (!gpu_memory_buffer)
66 return; 67 return;
67 68
68 RasterWorkerPool::ReleaseBitmapForBuffer( 69 RasterWorkerPool::ReleaseBitmapForBuffer(
69 &bitmap_, buffer_, resource_->format()); 70 &bitmap_, buffer_, resource_->format());
70 gpu_memory_buffer->Unmap(); 71 gpu_memory_buffer_->Unmap();
71 } 72 }
72 73
73 private: 74 private:
74 ResourceProvider* resource_provider_; 75 ResourceProvider* resource_provider_;
75 ResourcePool* resource_pool_; 76 ResourcePool* resource_pool_;
76 const Resource* resource_; 77 const Resource* resource_;
77 scoped_ptr<ScopedResource> raster_resource_; 78 scoped_ptr<ScopedResource> raster_resource_;
78 scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> lock_; 79 scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> lock_;
80 gfx::GpuMemoryBuffer* gpu_memory_buffer_;
79 void* buffer_; 81 void* buffer_;
80 SkBitmap bitmap_; 82 SkBitmap bitmap_;
81 83
82 DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl); 84 DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl);
83 }; 85 };
84 86
85 } // namespace 87 } // namespace
86 88
87 // static 89 // static
88 scoped_ptr<RasterWorkerPool> OneCopyRasterWorkerPool::Create( 90 scoped_ptr<RasterWorkerPool> OneCopyRasterWorkerPool::Create(
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 resource_pool_->total_memory_usage_bytes()); 277 resource_pool_->total_memory_usage_bytes());
276 staging_state->SetInteger("pending_copy_count", 278 staging_state->SetInteger("pending_copy_count",
277 resource_pool_->total_resource_count() - 279 resource_pool_->total_resource_count() -
278 resource_pool_->acquired_resource_count()); 280 resource_pool_->acquired_resource_count());
279 staging_state->SetInteger("bytes_pending_copy", 281 staging_state->SetInteger("bytes_pending_copy",
280 resource_pool_->total_memory_usage_bytes() - 282 resource_pool_->total_memory_usage_bytes() -
281 resource_pool_->acquired_memory_usage_bytes()); 283 resource_pool_->acquired_memory_usage_bytes());
282 } 284 }
283 285
284 } // namespace cc 286 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | cc/resources/resource_provider.h » ('j') | cc/resources/resource_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698