Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 645933003: Initial set of perf tests for classes. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback #

Patch Set 3 : Rebased patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -4 lines) Patch
A + test/js-perf-test/Classes/Classes.json View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
A + test/js-perf-test/Classes/run.js View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
A test/js-perf-test/Classes/super.js View 1 2 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
Erik, Andreas, please take a look. My strategy here is: 1. Only test scenarios that ...
6 years, 2 months ago (2014-10-16 19:32:04 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/645933003/diff/1/test/js-perf-test/Classes/super.js File test/js-perf-test/Classes/super.js (right): https://codereview.chromium.org/645933003/diff/1/test/js-perf-test/Classes/super.js#newcode47 test/js-perf-test/Classes/super.js:47: Object.setPrototypeOf(Derived, Base) too? Since that makes these look ...
6 years, 2 months ago (2014-10-16 19:36:56 UTC) #2
Dmitry Lomov (no reviews)
Thanks for review! Comments addressed. https://codereview.chromium.org/645933003/diff/1/test/js-perf-test/Classes/super.js File test/js-perf-test/Classes/super.js (right): https://codereview.chromium.org/645933003/diff/1/test/js-perf-test/Classes/super.js#newcode47 test/js-perf-test/Classes/super.js:47: On 2014/10/16 19:36:55, arv ...
6 years, 2 months ago (2014-10-16 19:43:29 UTC) #3
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-17 09:27:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24684 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698