Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 645933002: [Mac] Fix accessibility crash because I am terrible with dynamic types. (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix accessibility crash because I am terrible with dynamic types. Turns out attributes like AXPosition will crash with @[] :/ BUG=412707 TEST=Start Chrome with --enable-new-avatar-menu. Provided you have zooming enabled in your Mac Accessibility settings, press Ctrl and scroll up to zoom in. Click on the avatar button. The avatar bubble should open and Chrome should not crash. Committed: https://crrev.com/cc93e76168da60dbae624dcdb49da33ea0944b68 Cr-Commit-Position: refs/heads/master@{#299160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
noms (inactive)
6 years, 2 months ago (2014-10-10 15:00:29 UTC) #2
groby-ooo-7-16
Gah. LGTM, sorry for not catching it in the first place.
6 years, 2 months ago (2014-10-10 18:24:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645933002/1
6 years, 2 months ago (2014-10-10 18:27:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 19:23:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 19:24:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc93e76168da60dbae624dcdb49da33ea0944b68
Cr-Commit-Position: refs/heads/master@{#299160}

Powered by Google App Engine
This is Rietveld 408576698