Issue 64593002: Move MediaStreamSource to platform/

Issue 64593002: Move MediaStreamSource to platform/ (Closed)

Created:
7 years, 1 month ago by pilgrim_google

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, philipj_slow, tommyw+watchlist_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, darin (slow to review)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move MediaStreamSource to platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161639

Patch Set 4 : also move WebMediaConstraints.cpp #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -634 lines)			Patch
M	Source/core/core.gypi	View	1 2 3	2 chunks	+0 lines, -4 lines	0 comments	Download
D	Source/core/platform/chromium/support/WebMediaConstraints.cpp	View	1 2 3	1 chunk	+0 lines, -108 lines	0 comments	Download
M	Source/core/platform/chromium/support/WebMediaStream.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
D	Source/core/platform/chromium/support/WebMediaStreamSource.cpp	View		1 chunk	+0 lines, -246 lines	0 comments	Download
M	Source/core/platform/chromium/support/WebMediaStreamTrack.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/mediastream/MediaStreamComponent.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/mediastream/MediaStreamDescriptor.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/mediastream/MediaStreamDescriptor.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
D	Source/core/platform/mediastream/MediaStreamSource.h	View		1 chunk	+0 lines, -119 lines	0 comments	Download
D	Source/core/platform/mediastream/MediaStreamSource.cpp	View		1 chunk	+0 lines, -108 lines	0 comments	Download
M	Source/modules/mediastream/MediaStream.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/mediastream/MediaStreamTrack.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/mediastream/UserMediaRequest.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
A +	Source/platform/exported/WebMediaConstraints.cpp	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	Source/platform/exported/WebMediaStreamSource.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	Source/platform/mediastream/MediaStreamSource.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
A +	Source/platform/mediastream/MediaStreamSource.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/AssertMatchingEnums.cpp	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/web/UserMediaClientImpl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebUserMediaRequest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	public/platform/WebMediaConstraints.h	View	1	2 chunks	+11 lines, -11 lines	0 comments	Download
M	public/platform/WebMediaStreamSource.h	View	1	2 chunks	+25 lines, -25 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/64593002/diff/1/Source/platform/mediastream/MediaStreamSource.cpp File Source/platform/mediastream/MediaStreamSource.cpp (right): https://codereview.chromium.org/64593002/diff/1/Source/platform/mediastream/MediaStreamSource.cpp#newcode32 Source/platform/mediastream/MediaStreamSource.cpp:32: No need for this blank line https://codereview.chromium.org/64593002/diff/1/public/platform/WebMediaConstraints.h File ...

7 years, 1 month ago (2013-11-07 18:23:23 UTC) #2