Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 645883004: Make SkImageDecoder_libpng be compilable with Chromium libpng (Closed)

Created:
6 years, 2 months ago by Kimmo Kinnunen
Modified:
6 years, 2 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make SkImageDecoder_libpng be compilable with Chromium libpng Chromium has libpng with pngusr.h that disables certain functionality with defines. Use those defines when compiling SkImageDecoder_libpng.cpp. This makes it possible to use Skia PNG decoder and encoder when compiling dm with Chromium. Skia PNG decoder and encoder of course is not compiled to the skia library, but to dm with Chromium. BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/93b255b19e01a0f10ac3b9e20f2d8fedcb5e57ca

Patch Set 1 #

Total comments: 1

Patch Set 2 : address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/images/SkImageDecoder_libpng.cpp View 1 7 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Kimmo Kinnunen
6 years, 2 months ago (2014-10-16 11:25:04 UTC) #2
scroggo
https://codereview.chromium.org/645883004/diff/1/src/images/SkImageDecoder_libpng.cpp File src/images/SkImageDecoder_libpng.cpp (right): https://codereview.chromium.org/645883004/diff/1/src/images/SkImageDecoder_libpng.cpp#newcode502 src/images/SkImageDecoder_libpng.cpp:502: #if PNG_sBIT_SUPPORTED ifdef*
6 years, 2 months ago (2014-10-16 14:14:36 UTC) #3
Kimmo Kinnunen
On 2014/10/16 14:14:36, scroggo wrote: > https://codereview.chromium.org/645883004/diff/1/src/images/SkImageDecoder_libpng.cpp > File src/images/SkImageDecoder_libpng.cpp (right): > > https://codereview.chromium.org/645883004/diff/1/src/images/SkImageDecoder_libpng.cpp#newcode502 > ...
6 years, 2 months ago (2014-10-17 05:28:01 UTC) #4
scroggo
lgtm
6 years, 2 months ago (2014-10-17 14:08:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645883004/20001
6 years, 2 months ago (2014-10-20 05:01:19 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 05:07:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 93b255b19e01a0f10ac3b9e20f2d8fedcb5e57ca

Powered by Google App Engine
This is Rietveld 408576698