Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: ui/app_list/views/search_box_view_unittest.cc

Issue 645853013: Remove some platform specific stuff from views. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/app_list/views/search_box_view_delegate.h ('k') | ui/app_list/views/search_result_actions_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/search_box_view_unittest.cc
diff --git a/ui/app_list/views/search_box_view_unittest.cc b/ui/app_list/views/search_box_view_unittest.cc
deleted file mode 100644
index a1643a064e48025cbe40b9d3d8bf52bb16662b62..0000000000000000000000000000000000000000
--- a/ui/app_list/views/search_box_view_unittest.cc
+++ /dev/null
@@ -1,163 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "ui/app_list/views/search_box_view.h"
-
-#include <cctype>
-#include <map>
-
-#include "base/strings/utf_string_conversions.h"
-#include "ui/app_list/test/app_list_test_view_delegate.h"
-#include "ui/app_list/views/search_box_view_delegate.h"
-#include "ui/views/controls/textfield/textfield.h"
-#include "ui/views/test/widget_test.h"
-
-namespace app_list {
-namespace test {
-
-class KeyPressCounterView : public views::View {
- public:
- KeyPressCounterView() : count_(0) {}
- virtual ~KeyPressCounterView() {}
-
- int GetCountAndReset() {
- int count = count_;
- count_ = 0;
- return count;
- }
-
- private:
- // Overridden from views::View:
- virtual bool OnKeyPressed(const ui::KeyEvent& key_event) override {
- if (!::isalnum(static_cast<int>(key_event.key_code()))) {
- ++count_;
- return true;
- }
- return false;
- }
- int count_;
-
- DISALLOW_COPY_AND_ASSIGN(KeyPressCounterView);
-};
-
-class SearchBoxViewTest : public views::test::WidgetTest,
- public SearchBoxViewDelegate {
- public:
- SearchBoxViewTest() : query_changed_count_(0) {}
- virtual ~SearchBoxViewTest() {}
-
- // Overridden from testing::Test:
- virtual void SetUp() override {
- views::test::WidgetTest::SetUp();
- widget_ = CreateTopLevelPlatformWidget();
- view_ = new SearchBoxView(this, &view_delegate_);
- counter_view_ = new KeyPressCounterView();
- widget_->GetContentsView()->AddChildView(view_);
- widget_->GetContentsView()->AddChildView(counter_view_);
- view_->set_contents_view(counter_view_);
- }
-
- virtual void TearDown() override {
- widget_->CloseNow();
- views::test::WidgetTest::TearDown();
- }
-
- protected:
- SearchBoxView* view() { return view_; }
-
- void SetLongAutoLaunchTimeout() {
- // Sets a long timeout that lasts longer than the test run.
- view_delegate_.set_auto_launch_timeout(base::TimeDelta::FromDays(1));
- }
-
- base::TimeDelta GetAutoLaunchTimeout() {
- return view_delegate_.GetAutoLaunchTimeout();
- }
-
- void ResetAutoLaunchTimeout() {
- view_delegate_.set_auto_launch_timeout(base::TimeDelta());
- }
-
- int GetContentsViewKeyPressCountAndReset() {
- return counter_view_->GetCountAndReset();
- }
-
- void KeyPress(ui::KeyboardCode key_code) {
- ui::KeyEvent event(ui::ET_KEY_PRESSED, key_code, ui::EF_NONE);
- view_->search_box()->OnKeyPressed(event);
- // Emulates the input method.
- if (::isalnum(static_cast<int>(key_code))) {
- base::char16 character = ::tolower(static_cast<int>(key_code));
- view_->search_box()->InsertText(base::string16(1, character));
- }
- }
-
- std::string GetLastQueryAndReset() {
- base::string16 query = last_query_;
- last_query_.clear();
- return base::UTF16ToUTF8(query);
- }
-
- int GetQueryChangedCountAndReset() {
- int result = query_changed_count_;
- query_changed_count_ = 0;
- return result;
- }
-
- private:
- // Overridden from SearchBoxViewDelegate:
- virtual void QueryChanged(SearchBoxView* sender) override {
- ++query_changed_count_;
- last_query_ = sender->search_box()->text();
- }
-
- AppListTestViewDelegate view_delegate_;
- views::Widget* widget_;
- SearchBoxView* view_;
- KeyPressCounterView* counter_view_;
- base::string16 last_query_;
- int query_changed_count_;
-
- DISALLOW_COPY_AND_ASSIGN(SearchBoxViewTest);
-};
-
-TEST_F(SearchBoxViewTest, Basic) {
- KeyPress(ui::VKEY_A);
- EXPECT_EQ("a", GetLastQueryAndReset());
- EXPECT_EQ(1, GetQueryChangedCountAndReset());
- EXPECT_EQ(0, GetContentsViewKeyPressCountAndReset());
-
- KeyPress(ui::VKEY_DOWN);
- EXPECT_EQ(0, GetQueryChangedCountAndReset());
- EXPECT_EQ(1, GetContentsViewKeyPressCountAndReset());
-
- view()->ClearSearch();
- EXPECT_EQ(1, GetQueryChangedCountAndReset());
- EXPECT_TRUE(GetLastQueryAndReset().empty());
-}
-
-TEST_F(SearchBoxViewTest, CancelAutoLaunch) {
- SetLongAutoLaunchTimeout();
- ASSERT_NE(base::TimeDelta(), GetAutoLaunchTimeout());
-
- // Normal key event cancels the timeout.
- KeyPress(ui::VKEY_A);
- EXPECT_EQ(base::TimeDelta(), GetAutoLaunchTimeout());
- ResetAutoLaunchTimeout();
-
- // Unusual key event doesn't cancel -- it will be canceled in
- // SearchResultListView.
- SetLongAutoLaunchTimeout();
- KeyPress(ui::VKEY_DOWN);
- EXPECT_NE(base::TimeDelta(), GetAutoLaunchTimeout());
- ResetAutoLaunchTimeout();
-
- // Clearing search box also cancels.
- SetLongAutoLaunchTimeout();
- view()->ClearSearch();
- EXPECT_EQ(base::TimeDelta(), GetAutoLaunchTimeout());
-}
-
-} // namespace test
-} // namespace app_list
« no previous file with comments | « ui/app_list/views/search_box_view_delegate.h ('k') | ui/app_list/views/search_result_actions_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698