Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: gin/wrappable_unittest.cc

Issue 645853012: Standardize usage of virtual/override/final in gin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/test/file_runner.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/wrappable_unittest.cc
diff --git a/gin/wrappable_unittest.cc b/gin/wrappable_unittest.cc
index 0e10c326b5ca438dc725d3e1edb343a7f0ad9141..8dbaf30132536509ec0b746ca00ce5c4b65f399b 100644
--- a/gin/wrappable_unittest.cc
+++ b/gin/wrappable_unittest.cc
@@ -40,9 +40,8 @@ class MyObject : public BaseClass,
protected:
MyObject() : value_(0) {}
- virtual ObjectTemplateBuilder GetObjectTemplateBuilder(
- v8::Isolate* isolate) override;
- virtual ~MyObject() {}
+ ObjectTemplateBuilder GetObjectTemplateBuilder(v8::Isolate* isolate) override;
+ ~MyObject() override {}
private:
int value_;
@@ -61,7 +60,7 @@ class MyObjectSubclass : public MyObject {
std::string result;
private:
- virtual ObjectTemplateBuilder GetObjectTemplateBuilder(
+ ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override {
return MyObject::GetObjectTemplateBuilder(isolate)
.SetMethod("sayHello", &MyObjectSubclass::SayHello);
@@ -70,8 +69,7 @@ class MyObjectSubclass : public MyObject {
MyObjectSubclass() {
}
- virtual ~MyObjectSubclass() {
- }
+ ~MyObjectSubclass() override {}
};
class MyCallableObject : public Wrappable<MyCallableObject> {
@@ -85,7 +83,7 @@ class MyCallableObject : public Wrappable<MyCallableObject> {
int result() { return result_; }
private:
- virtual ObjectTemplateBuilder GetObjectTemplateBuilder(
+ ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) override {
return Wrappable<MyCallableObject>::GetObjectTemplateBuilder(isolate)
.SetCallAsFunctionHandler(&MyCallableObject::Call);
@@ -94,8 +92,7 @@ class MyCallableObject : public Wrappable<MyCallableObject> {
MyCallableObject() : result_(0) {
}
- virtual ~MyCallableObject() {
- }
+ ~MyCallableObject() override {}
void Call(int val, const gin::Arguments& arguments) {
if (arguments.IsConstructCall())
« no previous file with comments | « gin/test/file_runner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698