Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: gin/modules/module_runner_delegate.h

Issue 645853012: Standardize usage of virtual/override/final in gin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/modules/module_registry_unittest.cc ('k') | gin/modules/timer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_MODULES_MODULE_RUNNER_DELEGATE_H_ 5 #ifndef GIN_MODULES_MODULE_RUNNER_DELEGATE_H_
6 #define GIN_MODULES_MODULE_RUNNER_DELEGATE_H_ 6 #define GIN_MODULES_MODULE_RUNNER_DELEGATE_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "gin/gin_export.h" 12 #include "gin/gin_export.h"
13 #include "gin/modules/file_module_provider.h" 13 #include "gin/modules/file_module_provider.h"
14 #include "gin/shell_runner.h" 14 #include "gin/shell_runner.h"
15 #include "v8/include/v8.h" 15 #include "v8/include/v8.h"
16 16
17 namespace gin { 17 namespace gin {
18 18
19 typedef v8::Local<v8::Value> (*ModuleGetter)(v8::Isolate* isolate); 19 typedef v8::Local<v8::Value> (*ModuleGetter)(v8::Isolate* isolate);
20 typedef base::Callback<v8::Local<v8::Value>(v8::Isolate*)> ModuleGetterCallback; 20 typedef base::Callback<v8::Local<v8::Value>(v8::Isolate*)> ModuleGetterCallback;
21 21
22 // Emebedders that use AMD modules will probably want to use a RunnerDelegate 22 // Emebedders that use AMD modules will probably want to use a RunnerDelegate
23 // that inherits from ModuleRunnerDelegate. ModuleRunnerDelegate lets embedders 23 // that inherits from ModuleRunnerDelegate. ModuleRunnerDelegate lets embedders
24 // register built-in modules and routes module requests to FileModuleProvider. 24 // register built-in modules and routes module requests to FileModuleProvider.
25 class GIN_EXPORT ModuleRunnerDelegate : public ShellRunnerDelegate { 25 class GIN_EXPORT ModuleRunnerDelegate : public ShellRunnerDelegate {
26 public: 26 public:
27 explicit ModuleRunnerDelegate( 27 explicit ModuleRunnerDelegate(
28 const std::vector<base::FilePath>& search_paths); 28 const std::vector<base::FilePath>& search_paths);
29 virtual ~ModuleRunnerDelegate(); 29 ~ModuleRunnerDelegate() override;
30 30
31 void AddBuiltinModule(const std::string& id, ModuleGetter getter); 31 void AddBuiltinModule(const std::string& id, ModuleGetter getter);
32 void AddBuiltinModule(const std::string& id, 32 void AddBuiltinModule(const std::string& id,
33 const ModuleGetterCallback& getter); 33 const ModuleGetterCallback& getter);
34 34
35 protected: 35 protected:
36 void AttemptToLoadMoreModules(Runner* runner); 36 void AttemptToLoadMoreModules(Runner* runner);
37 37
38 private: 38 private:
39 typedef std::map<std::string, ModuleGetterCallback> BuiltinModuleMap; 39 typedef std::map<std::string, ModuleGetterCallback> BuiltinModuleMap;
40 40
41 // From ShellRunnerDelegate: 41 // From ShellRunnerDelegate:
42 virtual v8::Handle<v8::ObjectTemplate> GetGlobalTemplate( 42 v8::Handle<v8::ObjectTemplate> GetGlobalTemplate(
43 ShellRunner* runner, 43 ShellRunner* runner,
44 v8::Isolate* isolate) override; 44 v8::Isolate* isolate) override;
45 virtual void DidCreateContext(ShellRunner* runner) override; 45 void DidCreateContext(ShellRunner* runner) override;
46 virtual void DidRunScript(ShellRunner* runner) override; 46 void DidRunScript(ShellRunner* runner) override;
47 47
48 BuiltinModuleMap builtin_modules_; 48 BuiltinModuleMap builtin_modules_;
49 FileModuleProvider module_provider_; 49 FileModuleProvider module_provider_;
50 50
51 DISALLOW_COPY_AND_ASSIGN(ModuleRunnerDelegate); 51 DISALLOW_COPY_AND_ASSIGN(ModuleRunnerDelegate);
52 }; 52 };
53 53
54 } // namespace gin 54 } // namespace gin
55 55
56 #endif // GIN_MODULES_MODULE_RUNNER_DELEGATE_H_ 56 #endif // GIN_MODULES_MODULE_RUNNER_DELEGATE_H_
OLDNEW
« no previous file with comments | « gin/modules/module_registry_unittest.cc ('k') | gin/modules/timer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698