Chromium Code Reviews| Index: Source/modules/webaudio/AudioNode.h |
| diff --git a/Source/modules/webaudio/AudioNode.h b/Source/modules/webaudio/AudioNode.h |
| index 91d368353e26ed52ef03b2f56d4b0dbfb02eae97..b6ec173f638c8f7b5a22a239de59cbded56bdf26 100644 |
| --- a/Source/modules/webaudio/AudioNode.h |
| +++ b/Source/modules/webaudio/AudioNode.h |
| @@ -120,6 +120,14 @@ public: |
| virtual void initialize(); |
| virtual void uninitialize(); |
| + // Clear internal state when the node is disabled. When a node is disabled, |
| + // it is no longer pulled so any internal state is never updated. But some |
| + // nodes (DynamicsCompressorNode) have internal state that is still |
| + // accessible by the user. Update the internal state as if the node were |
| + // still connected but processing all zeroes. This gives a consistent view |
| + // to the user. |
|
Raymond Toy
2014/10/21 23:25:51
Nit: I think blink style is to use one space after
hongchan
2014/10/21 23:43:21
Acknowledged.
|
| + virtual void clearInternalStateWhenDisabled(); |
| + |
| bool isInitialized() const { return m_isInitialized; } |
| unsigned numberOfInputs() const { return m_inputs.size(); } |