Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: Source/modules/webaudio/AudioNode.h

Issue 645853010: Make reduction value of dynamics compressor zero when no sources are connected (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/AudioNode.h
diff --git a/Source/modules/webaudio/AudioNode.h b/Source/modules/webaudio/AudioNode.h
index 91d368353e26ed52ef03b2f56d4b0dbfb02eae97..7c80fb1864ecba2a1350eb77059e7a7791f74878 100644
--- a/Source/modules/webaudio/AudioNode.h
+++ b/Source/modules/webaudio/AudioNode.h
@@ -120,6 +120,10 @@ public:
virtual void initialize();
virtual void uninitialize();
+ // Clear internal state when the node is deactivated. This prevents the node
+ // from providing the incorrect data based on the last-known data inside.
Raymond Toy 2014/10/21 20:47:57 "deactivated" -> "disabled". I think this comment
hongchan 2014/10/21 20:58:54 Acknowledged and replaced.
+ virtual void clearInternalState();
Raymond Toy 2014/10/21 20:47:57 If the comment above is used, perhaps this functio
hongchan 2014/10/21 20:58:54 Good to be more descriptive. But I think this meth
Raymond Toy 2014/10/21 21:05:54 Hard to say what the future holds. Ok for now, as
+
bool isInitialized() const { return m_isInitialized; }
unsigned numberOfInputs() const { return m_inputs.size(); }

Powered by Google App Engine
This is Rietveld 408576698