Source/modules/webaudio/DynamicsCompressorNode.h - Issue 645853010: Make reduction value of dynamics compressor zero when no sources are connected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/DynamicsCompressorNode.h

Issue 645853010: Make reduction value of dynamics compressor zero when no sources are connected (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/webaudio/dynamicscompressor-clear-internal-state.html ('K') | « Source/modules/webaudio/AudioNode.cpp ('k') | Source/modules/webaudio/DynamicsCompressorNode.cpp » ('j') | Source/modules/webaudio/DynamicsCompressorNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webaudio/DynamicsCompressorNode.h

diff --git a/Source/modules/webaudio/DynamicsCompressorNode.h b/Source/modules/webaudio/DynamicsCompressorNode.h

index a1ca06a11da7eec7a9cdc76e81fe80266e4705ce..7d5cf2adaf0c44a8ff61b26db148b8688847579e 100644

--- a/Source/modules/webaudio/DynamicsCompressorNode.h

+++ b/Source/modules/webaudio/DynamicsCompressorNode.h

@@ -48,6 +48,7 @@ public:

virtual void process(size_t framesToProcess) override;

virtual void initialize() override;

virtual void uninitialize() override;

+ virtual void clearInternalState() override;

// Static compression curve parameters.

AudioParam* threshold() { return m_threshold.get(); }