Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: cc/trees/single_thread_proxy.h

Issue 645853008: Standardize usage of virtual/override/final in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/occlusion_tracker_unittest.cc ('k') | cc/trees/thread_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/single_thread_proxy.h
diff --git a/cc/trees/single_thread_proxy.h b/cc/trees/single_thread_proxy.h
index ed7b1015a86443011b654e5f994d5700996f6caf..89378f5717cdead1535241acab8d3276d7870df3 100644
--- a/cc/trees/single_thread_proxy.h
+++ b/cc/trees/single_thread_proxy.h
@@ -31,82 +31,79 @@ class CC_EXPORT SingleThreadProxy : public Proxy,
LayerTreeHost* layer_tree_host,
LayerTreeHostSingleThreadClient* client,
scoped_refptr<base::SingleThreadTaskRunner> main_task_runner);
- virtual ~SingleThreadProxy();
+ ~SingleThreadProxy() override;
// Proxy implementation
- virtual void FinishAllRendering() override;
- virtual bool IsStarted() const override;
- virtual void SetOutputSurface(scoped_ptr<OutputSurface>) override;
- virtual void SetLayerTreeHostClientReady() override;
- virtual void SetVisible(bool visible) override;
- virtual const RendererCapabilities& GetRendererCapabilities() const override;
- virtual void SetNeedsAnimate() override;
- virtual void SetNeedsUpdateLayers() override;
- virtual void SetNeedsCommit() override;
- virtual void SetNeedsRedraw(const gfx::Rect& damage_rect) override;
- virtual void SetNextCommitWaitsForActivation() override;
- virtual void NotifyInputThrottledUntilCommit() override {}
- virtual void SetDeferCommits(bool defer_commits) override;
- virtual bool CommitRequested() const override;
- virtual bool BeginMainFrameRequested() const override;
- virtual void MainThreadHasStoppedFlinging() override {}
- virtual void Start() override;
- virtual void Stop() override;
- virtual size_t MaxPartialTextureUpdates() const override;
- virtual void ForceSerializeOnSwapBuffers() override;
- virtual bool SupportsImplScrolling() const override;
- virtual void AsValueInto(base::debug::TracedValue* state) const override;
- virtual bool MainFrameWillHappenForTesting() override;
+ void FinishAllRendering() override;
+ bool IsStarted() const override;
+ void SetOutputSurface(scoped_ptr<OutputSurface>) override;
+ void SetLayerTreeHostClientReady() override;
+ void SetVisible(bool visible) override;
+ const RendererCapabilities& GetRendererCapabilities() const override;
+ void SetNeedsAnimate() override;
+ void SetNeedsUpdateLayers() override;
+ void SetNeedsCommit() override;
+ void SetNeedsRedraw(const gfx::Rect& damage_rect) override;
+ void SetNextCommitWaitsForActivation() override;
+ void NotifyInputThrottledUntilCommit() override {}
+ void SetDeferCommits(bool defer_commits) override;
+ bool CommitRequested() const override;
+ bool BeginMainFrameRequested() const override;
+ void MainThreadHasStoppedFlinging() override {}
+ void Start() override;
+ void Stop() override;
+ size_t MaxPartialTextureUpdates() const override;
+ void ForceSerializeOnSwapBuffers() override;
+ bool SupportsImplScrolling() const override;
+ void AsValueInto(base::debug::TracedValue* state) const override;
+ bool MainFrameWillHappenForTesting() override;
// SchedulerClient implementation
- virtual BeginFrameSource* ExternalBeginFrameSource() override;
- virtual void WillBeginImplFrame(const BeginFrameArgs& args) override;
- virtual void ScheduledActionSendBeginMainFrame() override;
- virtual DrawResult ScheduledActionDrawAndSwapIfPossible() override;
- virtual DrawResult ScheduledActionDrawAndSwapForced() override;
- virtual void ScheduledActionCommit() override;
- virtual void ScheduledActionAnimate() override;
- virtual void ScheduledActionUpdateVisibleTiles() override;
- virtual void ScheduledActionActivateSyncTree() override;
- virtual void ScheduledActionBeginOutputSurfaceCreation() override;
- virtual void ScheduledActionManageTiles() override;
- virtual void DidAnticipatedDrawTimeChange(base::TimeTicks time) override;
- virtual base::TimeDelta DrawDurationEstimate() override;
- virtual base::TimeDelta BeginMainFrameToCommitDurationEstimate() override;
- virtual base::TimeDelta CommitToActivateDurationEstimate() override;
- virtual void DidBeginImplFrameDeadline() override;
+ BeginFrameSource* ExternalBeginFrameSource() override;
+ void WillBeginImplFrame(const BeginFrameArgs& args) override;
+ void ScheduledActionSendBeginMainFrame() override;
+ DrawResult ScheduledActionDrawAndSwapIfPossible() override;
+ DrawResult ScheduledActionDrawAndSwapForced() override;
+ void ScheduledActionCommit() override;
+ void ScheduledActionAnimate() override;
+ void ScheduledActionUpdateVisibleTiles() override;
+ void ScheduledActionActivateSyncTree() override;
+ void ScheduledActionBeginOutputSurfaceCreation() override;
+ void ScheduledActionManageTiles() override;
+ void DidAnticipatedDrawTimeChange(base::TimeTicks time) override;
+ base::TimeDelta DrawDurationEstimate() override;
+ base::TimeDelta BeginMainFrameToCommitDurationEstimate() override;
+ base::TimeDelta CommitToActivateDurationEstimate() override;
+ void DidBeginImplFrameDeadline() override;
// LayerTreeHostImplClient implementation
- virtual void UpdateRendererCapabilitiesOnImplThread() override;
- virtual void DidLoseOutputSurfaceOnImplThread() override;
- virtual void CommitVSyncParameters(base::TimeTicks timebase,
- base::TimeDelta interval) override {}
- virtual void SetEstimatedParentDrawTime(base::TimeDelta draw_time) override {}
- virtual void SetMaxSwapsPendingOnImplThread(int max) override {}
- virtual void DidSwapBuffersOnImplThread() override;
- virtual void DidSwapBuffersCompleteOnImplThread() override;
- virtual void OnCanDrawStateChanged(bool can_draw) override;
- virtual void NotifyReadyToActivate() override;
- virtual void SetNeedsRedrawOnImplThread() override;
- virtual void SetNeedsRedrawRectOnImplThread(
- const gfx::Rect& dirty_rect) override;
- virtual void SetNeedsAnimateOnImplThread() override;
- virtual void SetNeedsManageTilesOnImplThread() override;
- virtual void DidInitializeVisibleTileOnImplThread() override;
- virtual void SetNeedsCommitOnImplThread() override;
- virtual void PostAnimationEventsToMainThreadOnImplThread(
+ void UpdateRendererCapabilitiesOnImplThread() override;
+ void DidLoseOutputSurfaceOnImplThread() override;
+ void CommitVSyncParameters(base::TimeTicks timebase,
+ base::TimeDelta interval) override {}
+ void SetEstimatedParentDrawTime(base::TimeDelta draw_time) override {}
+ void SetMaxSwapsPendingOnImplThread(int max) override {}
+ void DidSwapBuffersOnImplThread() override;
+ void DidSwapBuffersCompleteOnImplThread() override;
+ void OnCanDrawStateChanged(bool can_draw) override;
+ void NotifyReadyToActivate() override;
+ void SetNeedsRedrawOnImplThread() override;
+ void SetNeedsRedrawRectOnImplThread(const gfx::Rect& dirty_rect) override;
+ void SetNeedsAnimateOnImplThread() override;
+ void SetNeedsManageTilesOnImplThread() override;
+ void DidInitializeVisibleTileOnImplThread() override;
+ void SetNeedsCommitOnImplThread() override;
+ void PostAnimationEventsToMainThreadOnImplThread(
scoped_ptr<AnimationEventsVector> events) override;
- virtual bool ReduceContentsTextureMemoryOnImplThread(
- size_t limit_bytes,
- int priority_cutoff) override;
- virtual bool IsInsideDraw() override;
- virtual void RenewTreePriority() override {}
- virtual void PostDelayedScrollbarFadeOnImplThread(
- const base::Closure& start_fade,
- base::TimeDelta delay) override {}
- virtual void DidActivateSyncTree() override;
- virtual void DidManageTiles() override;
- virtual void SetDebugState(const LayerTreeDebugState& debug_state) override {}
+ bool ReduceContentsTextureMemoryOnImplThread(size_t limit_bytes,
+ int priority_cutoff) override;
+ bool IsInsideDraw() override;
+ void RenewTreePriority() override {}
+ void PostDelayedScrollbarFadeOnImplThread(const base::Closure& start_fade,
+ base::TimeDelta delay) override {}
+ void DidActivateSyncTree() override;
+ void DidManageTiles() override;
+ void SetDebugState(const LayerTreeDebugState& debug_state) override {}
void RequestNewOutputSurface();
« no previous file with comments | « cc/trees/occlusion_tracker_unittest.cc ('k') | cc/trees/thread_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698