Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: cc/output/gl_renderer.cc

Issue 645853008: Standardize usage of virtual/override/final in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.h ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index e8a2c9dbcca8b7ca2d04714088f2869a56b64b1f..61d233a4a7f17a26960ffc0e45cacfb4c9b1192e 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -56,8 +56,8 @@ class FallbackFence : public ResourceProvider::Fence {
: gl_(gl), has_passed_(true) {}
// Overridden from ResourceProvider::Fence:
- virtual void Set() override { has_passed_ = false; }
- virtual bool HasPassed() override {
+ void Set() override { has_passed_ = false; }
+ bool HasPassed() override {
if (!has_passed_) {
has_passed_ = true;
Synchronize();
@@ -66,7 +66,7 @@ class FallbackFence : public ResourceProvider::Fence {
}
private:
- virtual ~FallbackFence() {}
+ ~FallbackFence() override {}
void Synchronize() {
TRACE_EVENT0("cc", "FallbackFence::Synchronize");
@@ -251,16 +251,14 @@ class GLRenderer::SyncQuery {
: query_(query) {}
// Overridden from ResourceProvider::Fence:
- virtual void Set() override {
+ void Set() override {
DCHECK(query_);
query_->Set();
}
- virtual bool HasPassed() override {
- return !query_ || !query_->IsPending();
- }
+ bool HasPassed() override { return !query_ || !query_->IsPending(); }
private:
- virtual ~Fence() {}
+ ~Fence() override {}
base::WeakPtr<SyncQuery> query_;
« no previous file with comments | « cc/output/gl_renderer.h ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698