cc/layers/scrollbar_layer_impl_base.h - Issue 645853008: Standardize usage of virtual/override/final in cc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/scrollbar_layer_impl_base.h

Issue 645853008: Standardize usage of virtual/override/final in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/scrollbar_layer_impl_base.h

diff --git a/cc/layers/scrollbar_layer_impl_base.h b/cc/layers/scrollbar_layer_impl_base.h

index 85dc643b4e848c544777cb878de6799abf110e0c..4a96b49028f5a31bd7d6d86c4a05dd5b98f364d8 100644

--- a/cc/layers/scrollbar_layer_impl_base.h

+++ b/cc/layers/scrollbar_layer_impl_base.h

@@ -46,8 +46,8 @@ class CC_EXPORT ScrollbarLayerImplBase : public LayerImpl {

bool CanScrollOrientation() const;

- virtual void PushPropertiesTo(LayerImpl* layer) override;

- virtual ScrollbarLayerImplBase* ToScrollbarLayer() override;

+ void PushPropertiesTo(LayerImpl* layer) override;

+ ScrollbarLayerImplBase* ToScrollbarLayer() override;

void PushScrollClipPropertiesTo(LayerImpl* layer);

bool SetVisibleToTotalLengthRatio(float ratio);

@@ -66,7 +66,7 @@ class CC_EXPORT ScrollbarLayerImplBase : public LayerImpl {

ScrollbarOrientation orientation,

bool is_left_side_vertical_scrollbar,

bool is_overlay);

- virtual ~ScrollbarLayerImplBase();

+ ~ScrollbarLayerImplBase() override;

gfx::Rect ScrollbarLayerRectToContentRect(const gfx::RectF& layer_rect) const;

« no previous file with comments | « cc/layers/render_surface_unittest.cc ('k') | cc/layers/scrollbar_layer_unittest.cc » ('j') | no next file with comments »