cc/debug/unittest_only_benchmark.h - Issue 645853008: Standardize usage of virtual/override/final in cc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/debug/unittest_only_benchmark.h

Issue 645853008: Standardize usage of virtual/override/final in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/debug/unittest_only_benchmark.h

diff --git a/cc/debug/unittest_only_benchmark.h b/cc/debug/unittest_only_benchmark.h

index 277d85f573091a0aa805a8f715e1a06e3038144e..7fa2b4dcab4e98eda18f17c5d413692617e63eb3 100644

--- a/cc/debug/unittest_only_benchmark.h

+++ b/cc/debug/unittest_only_benchmark.h

@@ -14,13 +14,13 @@ class CC_EXPORT UnittestOnlyBenchmark : public MicroBenchmark {

public:

UnittestOnlyBenchmark(scoped_ptr<base::Value> value,

const DoneCallback& callback);

- virtual ~UnittestOnlyBenchmark();

+ ~UnittestOnlyBenchmark() override;

- virtual void DidUpdateLayers(LayerTreeHost* host) override;

- virtual bool ProcessMessage(scoped_ptr<base::Value> value) override;

+ void DidUpdateLayers(LayerTreeHost* host) override;

+ bool ProcessMessage(scoped_ptr<base::Value> value) override;

protected:

- virtual scoped_ptr<MicroBenchmarkImpl> CreateBenchmarkImpl(

+ scoped_ptr<MicroBenchmarkImpl> CreateBenchmarkImpl(

scoped_refptr<base::MessageLoopProxy> origin_loop) override;

private:

« no previous file with comments | « cc/debug/traced_picture.h ('k') | cc/debug/unittest_only_benchmark_impl.h » ('j') | no next file with comments »