cc/debug/rasterize_and_record_benchmark_impl.h - Issue 645853008: Standardize usage of virtual/override/final in cc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/debug/rasterize_and_record_benchmark_impl.h

Issue 645853008: Standardize usage of virtual/override/final in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/debug/rasterize_and_record_benchmark_impl.h

diff --git a/cc/debug/rasterize_and_record_benchmark_impl.h b/cc/debug/rasterize_and_record_benchmark_impl.h

index 4508d5e5cb062b090928c1bb026932263008426f..c0f26fd37046995c62d2fe3e9c9adfca9a73cde3 100644

--- a/cc/debug/rasterize_and_record_benchmark_impl.h

+++ b/cc/debug/rasterize_and_record_benchmark_impl.h

@@ -24,11 +24,11 @@ class RasterizeAndRecordBenchmarkImpl : public MicroBenchmarkImpl {

scoped_refptr<base::MessageLoopProxy> origin_loop,

base::Value* value,

const MicroBenchmarkImpl::DoneCallback& callback);

- virtual ~RasterizeAndRecordBenchmarkImpl();

+ ~RasterizeAndRecordBenchmarkImpl() override;

// Implements MicroBenchmark interface.

- virtual void DidCompleteCommit(LayerTreeHostImpl* host) override;

- virtual void RunOnLayer(PictureLayerImpl* layer) override;

+ void DidCompleteCommit(LayerTreeHostImpl* host) override;

+ void RunOnLayer(PictureLayerImpl* layer) override;

private:

void Run(LayerImpl* layer);