cc/animation/scrollbar_animation_controller_linear_fade.h - Issue 645853008: Standardize usage of virtual/override/final in cc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/scrollbar_animation_controller_linear_fade.h

Issue 645853008: Standardize usage of virtual/override/final in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatted Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/animation/scrollbar_animation_controller_linear_fade.h

diff --git a/cc/animation/scrollbar_animation_controller_linear_fade.h b/cc/animation/scrollbar_animation_controller_linear_fade.h

index 86524f2e58b6486c2667c3c1d9e705628ff566d7..73d60311fef4859ecf9d11de54c5b5d58a9df072 100644

--- a/cc/animation/scrollbar_animation_controller_linear_fade.h

+++ b/cc/animation/scrollbar_animation_controller_linear_fade.h

@@ -22,9 +22,9 @@ class CC_EXPORT ScrollbarAnimationControllerLinearFade

base::TimeDelta resize_delay_before_starting,

base::TimeDelta duration);

- virtual ~ScrollbarAnimationControllerLinearFade();

+ ~ScrollbarAnimationControllerLinearFade() override;

- virtual void DidScrollUpdate(bool on_resize) override;

+ void DidScrollUpdate(bool on_resize) override;

protected:

ScrollbarAnimationControllerLinearFade(

@@ -34,7 +34,7 @@ class CC_EXPORT ScrollbarAnimationControllerLinearFade

base::TimeDelta resize_delay_before_starting,

base::TimeDelta duration);

- virtual void RunAnimationFrame(float progress) override;

+ void RunAnimationFrame(float progress) override;

private:

float OpacityAtTime(base::TimeTicks now) const;