Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: cc/resources/raster_worker_pool_unittest.cc

Issue 645853008: Standardize usage of virtual/override/final in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/resources/raster_worker_pool_perftest.cc ('k') | cc/resources/rasterizer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/raster_worker_pool.h" 5 #include "cc/resources/raster_worker_pool.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/cancelable_callback.h" 10 #include "base/cancelable_callback.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 TestRasterTaskImpl(const Resource* resource, 52 TestRasterTaskImpl(const Resource* resource,
53 const Reply& reply, 53 const Reply& reply,
54 ImageDecodeTask::Vector* dependencies) 54 ImageDecodeTask::Vector* dependencies)
55 : RasterTask(resource, dependencies), 55 : RasterTask(resource, dependencies),
56 reply_(reply), 56 reply_(reply),
57 picture_pile_(FakePicturePileImpl::CreateEmptyPile(gfx::Size(1, 1), 57 picture_pile_(FakePicturePileImpl::CreateEmptyPile(gfx::Size(1, 1),
58 gfx::Size(1, 1))) {} 58 gfx::Size(1, 1))) {}
59 59
60 // Overridden from Task: 60 // Overridden from Task:
61 virtual void RunOnWorkerThread() override { 61 void RunOnWorkerThread() override {
62 raster_buffer_->Playback( 62 raster_buffer_->Playback(
63 picture_pile_.get(), gfx::Rect(0, 0, 1, 1), 1.0, NULL); 63 picture_pile_.get(), gfx::Rect(0, 0, 1, 1), 1.0, NULL);
64 } 64 }
65 65
66 // Overridden from RasterizerTask: 66 // Overridden from RasterizerTask:
67 virtual void ScheduleOnOriginThread(RasterizerTaskClient* client) override { 67 void ScheduleOnOriginThread(RasterizerTaskClient* client) override {
68 raster_buffer_ = client->AcquireBufferForRaster(resource()); 68 raster_buffer_ = client->AcquireBufferForRaster(resource());
69 } 69 }
70 virtual void CompleteOnOriginThread(RasterizerTaskClient* client) override { 70 void CompleteOnOriginThread(RasterizerTaskClient* client) override {
71 client->ReleaseBufferForRaster(raster_buffer_.Pass()); 71 client->ReleaseBufferForRaster(raster_buffer_.Pass());
72 } 72 }
73 virtual void RunReplyOnOriginThread() override { 73 void RunReplyOnOriginThread() override {
74 reply_.Run(PicturePileImpl::Analysis(), !HasFinishedRunning()); 74 reply_.Run(PicturePileImpl::Analysis(), !HasFinishedRunning());
75 } 75 }
76 76
77 protected: 77 protected:
78 virtual ~TestRasterTaskImpl() {} 78 ~TestRasterTaskImpl() override {}
79 79
80 private: 80 private:
81 const Reply reply_; 81 const Reply reply_;
82 scoped_ptr<RasterBuffer> raster_buffer_; 82 scoped_ptr<RasterBuffer> raster_buffer_;
83 scoped_refptr<PicturePileImpl> picture_pile_; 83 scoped_refptr<PicturePileImpl> picture_pile_;
84 84
85 DISALLOW_COPY_AND_ASSIGN(TestRasterTaskImpl); 85 DISALLOW_COPY_AND_ASSIGN(TestRasterTaskImpl);
86 }; 86 };
87 87
88 class BlockingTestRasterTaskImpl : public TestRasterTaskImpl { 88 class BlockingTestRasterTaskImpl : public TestRasterTaskImpl {
89 public: 89 public:
90 BlockingTestRasterTaskImpl(const Resource* resource, 90 BlockingTestRasterTaskImpl(const Resource* resource,
91 const Reply& reply, 91 const Reply& reply,
92 base::Lock* lock, 92 base::Lock* lock,
93 ImageDecodeTask::Vector* dependencies) 93 ImageDecodeTask::Vector* dependencies)
94 : TestRasterTaskImpl(resource, reply, dependencies), lock_(lock) {} 94 : TestRasterTaskImpl(resource, reply, dependencies), lock_(lock) {}
95 95
96 // Overridden from Task: 96 // Overridden from Task:
97 virtual void RunOnWorkerThread() override { 97 void RunOnWorkerThread() override {
98 base::AutoLock lock(*lock_); 98 base::AutoLock lock(*lock_);
99 TestRasterTaskImpl::RunOnWorkerThread(); 99 TestRasterTaskImpl::RunOnWorkerThread();
100 } 100 }
101 101
102 // Overridden from RasterizerTask: 102 // Overridden from RasterizerTask:
103 virtual void RunReplyOnOriginThread() override {} 103 void RunReplyOnOriginThread() override {}
104 104
105 protected: 105 protected:
106 virtual ~BlockingTestRasterTaskImpl() {} 106 ~BlockingTestRasterTaskImpl() override {}
107 107
108 private: 108 private:
109 base::Lock* lock_; 109 base::Lock* lock_;
110 110
111 DISALLOW_COPY_AND_ASSIGN(BlockingTestRasterTaskImpl); 111 DISALLOW_COPY_AND_ASSIGN(BlockingTestRasterTaskImpl);
112 }; 112 };
113 113
114 class RasterWorkerPoolTest 114 class RasterWorkerPoolTest
115 : public testing::TestWithParam<RasterWorkerPoolType>, 115 : public testing::TestWithParam<RasterWorkerPoolType>,
116 public RasterizerClient { 116 public RasterizerClient {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 DCHECK(raster_worker_pool_); 178 DCHECK(raster_worker_pool_);
179 raster_worker_pool_->AsRasterizer()->SetClient(this); 179 raster_worker_pool_->AsRasterizer()->SetClient(this);
180 } 180 }
181 181
182 virtual void TearDown() override { 182 virtual void TearDown() override {
183 raster_worker_pool_->AsRasterizer()->Shutdown(); 183 raster_worker_pool_->AsRasterizer()->Shutdown();
184 raster_worker_pool_->AsRasterizer()->CheckForCompletedTasks(); 184 raster_worker_pool_->AsRasterizer()->CheckForCompletedTasks();
185 } 185 }
186 186
187 // Overriden from RasterWorkerPoolClient: 187 // Overriden from RasterWorkerPoolClient:
188 virtual void DidFinishRunningTasks(TaskSet task_set) override { 188 void DidFinishRunningTasks(TaskSet task_set) override {
189 if (task_set == ALL) { 189 if (task_set == ALL) {
190 raster_worker_pool_->AsRasterizer()->CheckForCompletedTasks(); 190 raster_worker_pool_->AsRasterizer()->CheckForCompletedTasks();
191 base::MessageLoop::current()->Quit(); 191 base::MessageLoop::current()->Quit();
192 } 192 }
193 } 193 }
194 virtual TaskSetCollection TasksThatShouldBeForcedToComplete() const override { 194 TaskSetCollection TasksThatShouldBeForcedToComplete() const override {
195 return TaskSetCollection(); 195 return TaskSetCollection();
196 } 196 }
197 197
198 void RunMessageLoopUntilAllTasksHaveCompleted() { 198 void RunMessageLoopUntilAllTasksHaveCompleted() {
199 if (timeout_seconds_) { 199 if (timeout_seconds_) {
200 timeout_.Reset( 200 timeout_.Reset(
201 base::Bind(&RasterWorkerPoolTest::OnTimeout, base::Unretained(this))); 201 base::Bind(&RasterWorkerPoolTest::OnTimeout, base::Unretained(this)));
202 base::MessageLoopProxy::current()->PostDelayedTask( 202 base::MessageLoopProxy::current()->PostDelayedTask(
203 FROM_HERE, 203 FROM_HERE,
204 timeout_.callback(), 204 timeout_.callback(),
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 INSTANTIATE_TEST_CASE_P(RasterWorkerPoolTests, 403 INSTANTIATE_TEST_CASE_P(RasterWorkerPoolTests,
404 RasterWorkerPoolTest, 404 RasterWorkerPoolTest,
405 ::testing::Values(RASTER_WORKER_POOL_TYPE_PIXEL_BUFFER, 405 ::testing::Values(RASTER_WORKER_POOL_TYPE_PIXEL_BUFFER,
406 RASTER_WORKER_POOL_TYPE_ZERO_COPY, 406 RASTER_WORKER_POOL_TYPE_ZERO_COPY,
407 RASTER_WORKER_POOL_TYPE_ONE_COPY, 407 RASTER_WORKER_POOL_TYPE_ONE_COPY,
408 RASTER_WORKER_POOL_TYPE_GPU, 408 RASTER_WORKER_POOL_TYPE_GPU,
409 RASTER_WORKER_POOL_TYPE_BITMAP)); 409 RASTER_WORKER_POOL_TYPE_BITMAP));
410 410
411 } // namespace 411 } // namespace
412 } // namespace cc 412 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/raster_worker_pool_perftest.cc ('k') | cc/resources/rasterizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698