Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: cc/resources/raster_worker_pool.cc

Issue 645853008: Standardize usage of virtual/override/final in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Formatted Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/raster_worker_pool.h" 5 #include "cc/resources/raster_worker_pool.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/debug/trace_event.h" 9 #include "base/debug/trace_event.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 18 matching lines...) Expand all
29 static_cast<unsigned>(workers_.size() + 1)) 29 static_cast<unsigned>(workers_.size() + 1))
30 .c_str())); 30 .c_str()));
31 worker->Start(); 31 worker->Start();
32 #if defined(OS_ANDROID) || defined(OS_LINUX) 32 #if defined(OS_ANDROID) || defined(OS_LINUX)
33 worker->SetThreadPriority(base::kThreadPriority_Background); 33 worker->SetThreadPriority(base::kThreadPriority_Background);
34 #endif 34 #endif
35 workers_.push_back(worker.Pass()); 35 workers_.push_back(worker.Pass());
36 } 36 }
37 } 37 }
38 38
39 virtual ~RasterTaskGraphRunner() { NOTREACHED(); } 39 ~RasterTaskGraphRunner() override { NOTREACHED(); }
40 40
41 private: 41 private:
42 // Overridden from base::DelegateSimpleThread::Delegate: 42 // Overridden from base::DelegateSimpleThread::Delegate:
43 virtual void Run() override { 43 void Run() override { TaskGraphRunner::Run(); }
44 TaskGraphRunner::Run();
45 }
46 44
47 ScopedPtrDeque<base::DelegateSimpleThread> workers_; 45 ScopedPtrDeque<base::DelegateSimpleThread> workers_;
48 }; 46 };
49 47
50 base::LazyInstance<RasterTaskGraphRunner>::Leaky g_task_graph_runner = 48 base::LazyInstance<RasterTaskGraphRunner>::Leaky g_task_graph_runner =
51 LAZY_INSTANCE_INITIALIZER; 49 LAZY_INSTANCE_INITIALIZER;
52 50
53 const int kDefaultNumRasterThreads = 1; 51 const int kDefaultNumRasterThreads = 1;
54 52
55 int g_num_raster_threads = 0; 53 int g_num_raster_threads = 0;
56 54
57 class RasterFinishedTaskImpl : public RasterizerTask { 55 class RasterFinishedTaskImpl : public RasterizerTask {
58 public: 56 public:
59 explicit RasterFinishedTaskImpl( 57 explicit RasterFinishedTaskImpl(
60 base::SequencedTaskRunner* task_runner, 58 base::SequencedTaskRunner* task_runner,
61 const base::Closure& on_raster_finished_callback) 59 const base::Closure& on_raster_finished_callback)
62 : task_runner_(task_runner), 60 : task_runner_(task_runner),
63 on_raster_finished_callback_(on_raster_finished_callback) {} 61 on_raster_finished_callback_(on_raster_finished_callback) {}
64 62
65 // Overridden from Task: 63 // Overridden from Task:
66 virtual void RunOnWorkerThread() override { 64 void RunOnWorkerThread() override {
67 TRACE_EVENT0("cc", "RasterFinishedTaskImpl::RunOnWorkerThread"); 65 TRACE_EVENT0("cc", "RasterFinishedTaskImpl::RunOnWorkerThread");
68 RasterFinished(); 66 RasterFinished();
69 } 67 }
70 68
71 // Overridden from RasterizerTask: 69 // Overridden from RasterizerTask:
72 virtual void ScheduleOnOriginThread(RasterizerTaskClient* client) override {} 70 void ScheduleOnOriginThread(RasterizerTaskClient* client) override {}
73 virtual void CompleteOnOriginThread(RasterizerTaskClient* client) override {} 71 void CompleteOnOriginThread(RasterizerTaskClient* client) override {}
74 virtual void RunReplyOnOriginThread() override {} 72 void RunReplyOnOriginThread() override {}
75 73
76 protected: 74 protected:
77 virtual ~RasterFinishedTaskImpl() {} 75 ~RasterFinishedTaskImpl() override {}
78 76
79 void RasterFinished() { 77 void RasterFinished() {
80 task_runner_->PostTask(FROM_HERE, on_raster_finished_callback_); 78 task_runner_->PostTask(FROM_HERE, on_raster_finished_callback_);
81 } 79 }
82 80
83 private: 81 private:
84 scoped_refptr<base::SequencedTaskRunner> task_runner_; 82 scoped_refptr<base::SequencedTaskRunner> task_runner_;
85 const base::Closure on_raster_finished_callback_; 83 const base::Closure on_raster_finished_callback_;
86 84
87 DISALLOW_COPY_AND_ASSIGN(RasterFinishedTaskImpl); 85 DISALLOW_COPY_AND_ASSIGN(RasterFinishedTaskImpl);
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 // bitmap data. There will be no need to call SkAlign4 once crbug.com/293728 235 // bitmap data. There will be no need to call SkAlign4 once crbug.com/293728
238 // is fixed. 236 // is fixed.
239 const size_t dst_row_bytes = SkAlign4(dst_info.minRowBytes()); 237 const size_t dst_row_bytes = SkAlign4(dst_info.minRowBytes());
240 DCHECK_EQ(0u, dst_row_bytes % 4); 238 DCHECK_EQ(0u, dst_row_bytes % 4);
241 bool success = bitmap.readPixels(dst_info, memory, dst_row_bytes, 0, 0); 239 bool success = bitmap.readPixels(dst_info, memory, dst_row_bytes, 0, 0);
242 DCHECK_EQ(true, success); 240 DCHECK_EQ(true, success);
243 } 241 }
244 } 242 }
245 243
246 } // namespace cc 244 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/pixel_buffer_raster_worker_pool.cc ('k') | cc/resources/raster_worker_pool_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698