Issue 645833002: Refactor interface.cpp and interface_base.cpp for partial interface modularization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 645833002: Refactor interface.cpp and interface_base.cpp for partial interface modularization. (Closed)

Created:
6 years, 2 months ago by tasak

Modified:
6 years, 2 months ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Refactor interface.cpp and interface_base.cpp for partial interface modularization. Moved the following blocks from interface.cpp to interface_base.cpp: - security_check_functions, - install_conditional_attributes, and - install_conditional_methods BUG=380523 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183646

Patch Set 1 : #

Patch Set 2 : Patch for landing #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -68 lines)			Patch
	M	Source/bindings/templates/interface.cpp	View		2 chunks	+0 lines, -65 lines	0 comments	Download
	M	Source/bindings/templates/interface_base.cpp	View		2 chunks	+60 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645833002/210001

6 years, 2 months ago (2014-10-14 05:35:14 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-14 06:46:29 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:210001) as 183646

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages