Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 645803003: bug_chomper: Use parenthesized declaration style for const and vars. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

bug_chomper: Use parenthesized declaration style for const and vars. It seems cleaner that way and nicer to read, also avoids repeating 'const' and 'var' everytime you have to add more items. BUG=None TEST=./run_server.sh R=borenet@google.com Committed: https://skia.googlesource.com/skia/+/10c2c74d5003b0d8e9b134f92b0c791eb6733fec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M tools/bug_chomper/src/server/server.go View 1 chunk +25 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
Is this cleanup fine?
6 years, 2 months ago (2014-10-10 04:38:42 UTC) #1
borenet
LGTM
6 years, 2 months ago (2014-10-10 12:37:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645803003/1
6 years, 2 months ago (2014-10-11 01:33:53 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 01:41:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 10c2c74d5003b0d8e9b134f92b0c791eb6733fec

Powered by Google App Engine
This is Rietveld 408576698