Issue 645773002: Turn SkCanvasStateUtils into a class with static functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 645773002: Turn SkCanvasStateUtils into a class with static functions. (Closed)

Created:
6 years, 2 months ago by tfarina

Modified:
6 years, 2 months ago

Reviewers:
reed1

CC:
reviews_skia.org, mtklein

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Turn SkCanvasStateUtils into a class with static functions. That simplifies the way to declare it a friend, as needed in SkCanvas. BUG=skia:2914 TEST=make most R=reed@google.com Committed: https://skia.googlesource.com/skia/+/a5414c4a8efc3119ee20fcee96c0bf68a04909c7

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -10 lines)			Patch
M	gm/beziers.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkCanvas.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	include/utils/SkCanvasStateUtils.h	View	4 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645773002/1

6 years, 2 months ago (2014-10-10 13:10:23 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-10 13:19:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as a5414c4a8efc3119ee20fcee96c0bf68a04909c7