Refactor GeofencingManager to have one instance per StoragePartition.

content/browser/geofencing/geofencing_registration_delegate.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_GEOFENCING_GEOFENCING_REGISTRATION_DELEGATE_H_
+#define CONTENT_BROWSER_GEOFENCING_GEOFENCING_REGISTRATION_DELEGATE_H_
+
+#include "base/basictypes.h"
+#include "content/common/geofencing_status.h"
+
+namespace content {
+
+// |GeofencingService| has an instance of this class associated with each
+// geofence registration, and uses it to inform about events related to the
+// registration, such as the geofence finishing being registered.
+// These methods will always be called on the IO thread.
+// TODO(mek): Add methods for geofence enter/leave events.
+class GeofencingRegistrationDelegate {
+ public:
+  virtual ~GeofencingRegistrationDelegate() {}

[michaeln, 2014/10/23 20:27:06]

The ownership semantics of the GeofencingRegistrationDelegates is not clear from
looking at GeofencingService and GeofencingRegistrationDelegate class
interfaces. Also nothing mentioned about that in the doc comments.

If ownership is transferred to the GeofencingService, it could be provided as a
scoped_ptr<>. If ownership is not transferred, the virtual dtor could be
protected.

[Marijn Kruisselbrink, 2014/10/23 20:54:35]

Ah yes, good point Made the destructor protected and added a comment to
GeofencingService.

+  virtual void RegistrationFinished(int64 geofencing_registration_id,
+                                    GeofencingStatus status) = 0;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_GEOFENCING_GEOFENCING_REGISTRATION_DELEGATE_H_