tools/perf/measurements/repaint_unittest.py - Issue 645753002: telemetry: Replace mostly_smooth by percentage_smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/repaint_unittest.py

Issue 645753002: telemetry: Replace mostly_smooth by percentage_smooth. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/repaint_unittest.py

diff --git a/tools/perf/measurements/repaint_unittest.py b/tools/perf/measurements/repaint_unittest.py

index 33c8cfc5d618da0d031ba573be94816e548e3a11..40a910f45f1fbccb6c61a810702ae88f67e0bfd2 100644

--- a/tools/perf/measurements/repaint_unittest.py

+++ b/tools/perf/measurements/repaint_unittest.py

@@ -50,9 +50,10 @@ class RepaintUnitTest(page_test_test_case.PageTestTestCase):

self.assertEquals(len(jank), 1)

self.assertGreater(jank[0].GetRepresentativeNumber(), 0)

- mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth')

- self.assertEquals(len(mostly_smooth), 1)

- self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0)

+ percentage_smooth = results.FindAllPageSpecificValuesNamed(

+ 'percentage_smooth')

+ self.assertEquals(len(percentage_smooth), 1)

+ self.assertGreaterEqual(percentage_smooth[0].GetRepresentativeNumber(), 0)

@test.Disabled('android')

def testCleanUpTrace(self):

« no previous file with comments | « no previous file | tools/perf/measurements/smoothness_unittest.py » ('j') | tools/telemetry/telemetry/web_perf/metrics/smoothness.py » ('J')