Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: tools/perf/measurements/repaint_unittest.py

Issue 645753002: telemetry: Replace mostly_smooth by percentage_smooth. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test. Lower threshold to 17ms. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/smoothness_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from measurements import repaint 5 from measurements import repaint
6 from telemetry.core import wpr_modes 6 from telemetry.core import wpr_modes
7 from telemetry.page import page as page_module 7 from telemetry.page import page as page_module
8 from telemetry.unittest import options_for_unittests 8 from telemetry.unittest import options_for_unittests
9 from telemetry.unittest import page_test_test_case 9 from telemetry.unittest import page_test_test_case
10 from telemetry.unittest import test 10 from telemetry.unittest import test
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0) 43 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0)
44 44
45 mean_frame_time = results.FindAllPageSpecificValuesNamed('mean_frame_time') 45 mean_frame_time = results.FindAllPageSpecificValuesNamed('mean_frame_time')
46 self.assertEquals(len(mean_frame_time), 1) 46 self.assertEquals(len(mean_frame_time), 1)
47 self.assertGreater(mean_frame_time[0].GetRepresentativeNumber(), 0) 47 self.assertGreater(mean_frame_time[0].GetRepresentativeNumber(), 0)
48 48
49 jank = results.FindAllPageSpecificValuesNamed('jank') 49 jank = results.FindAllPageSpecificValuesNamed('jank')
50 self.assertEquals(len(jank), 1) 50 self.assertEquals(len(jank), 1)
51 self.assertGreater(jank[0].GetRepresentativeNumber(), 0) 51 self.assertGreater(jank[0].GetRepresentativeNumber(), 0)
52 52
53 mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth') 53 percentage_smooth = results.FindAllPageSpecificValuesNamed(
54 self.assertEquals(len(mostly_smooth), 1) 54 'percentage_smooth')
55 self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0) 55 self.assertEquals(len(percentage_smooth), 1)
56 self.assertGreaterEqual(percentage_smooth[0].GetRepresentativeNumber(), 0)
56 57
57 @test.Disabled('android') 58 @test.Disabled('android')
58 def testCleanUpTrace(self): 59 def testCleanUpTrace(self):
59 self.TestTracingCleanedUp(repaint.Repaint, self._options) 60 self.TestTracingCleanedUp(repaint.Repaint, self._options)
OLDNEW
« no previous file with comments | « no previous file | tools/perf/measurements/smoothness_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698