Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: tools/perf/measurements/smoothness_unittest.py

Issue 645753002: telemetry: Replace mostly_smooth by percentage_smooth. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import sys 4 import sys
5 5
6 from measurements import smoothness 6 from measurements import smoothness
7 from metrics import power 7 from metrics import power
8 from telemetry.core import exceptions 8 from telemetry.core import exceptions
9 from telemetry.core import wpr_modes 9 from telemetry.core import wpr_modes
10 from telemetry.page import page 10 from telemetry.page import page
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0) 109 self.assertGreater(frame_times[0].GetRepresentativeNumber(), 0)
110 110
111 mean_frame_time = results.FindAllPageSpecificValuesNamed('mean_frame_time') 111 mean_frame_time = results.FindAllPageSpecificValuesNamed('mean_frame_time')
112 self.assertEquals(len(mean_frame_time), 1) 112 self.assertEquals(len(mean_frame_time), 1)
113 self.assertGreater(mean_frame_time[0].GetRepresentativeNumber(), 0) 113 self.assertGreater(mean_frame_time[0].GetRepresentativeNumber(), 0)
114 114
115 jank = results.FindAllPageSpecificValuesNamed('jank') 115 jank = results.FindAllPageSpecificValuesNamed('jank')
116 self.assertEquals(len(jank), 1) 116 self.assertEquals(len(jank), 1)
117 self.assertGreater(jank[0].GetRepresentativeNumber(), 0) 117 self.assertGreater(jank[0].GetRepresentativeNumber(), 0)
118 118
119 mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth') 119 percentage_smooth = results.FindAllPageSpecificValuesNamed(
120 self.assertEquals(len(mostly_smooth), 1) 120 'percentage_smooth')
121 self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0) 121 self.assertEquals(len(percentage_smooth), 1)
122 self.assertGreaterEqual(percentage_smooth[0].GetRepresentativeNumber(), 0)
122 123
123 mean_input_event_latency = results.FindAllPageSpecificValuesNamed( 124 mean_input_event_latency = results.FindAllPageSpecificValuesNamed(
124 'mean_input_event_latency') 125 'mean_input_event_latency')
125 if mean_input_event_latency: 126 if mean_input_event_latency:
126 self.assertEquals(len(mean_input_event_latency), 1) 127 self.assertEquals(len(mean_input_event_latency), 1)
127 self.assertGreater( 128 self.assertGreater(
128 mean_input_event_latency[0].GetRepresentativeNumber(), 0) 129 mean_input_event_latency[0].GetRepresentativeNumber(), 0)
129 130
130 @test.Disabled('mac', 'chromeos') # http://crbug.com/403903 131 @test.Disabled('mac', 'chromeos') # http://crbug.com/403903
131 def testSmoothnessForPageWithNoGesture(self): 132 def testSmoothnessForPageWithNoGesture(self):
132 ps = self.CreateEmptyPageSet() 133 ps = self.CreateEmptyPageSet()
133 ps.AddPage(AnimatedPage(ps)) 134 ps.AddPage(AnimatedPage(ps))
134 135
135 measurement = smoothness.Smoothness() 136 measurement = smoothness.Smoothness()
136 results = self.RunMeasurement(measurement, ps, options=self._options) 137 results = self.RunMeasurement(measurement, ps, options=self._options)
137 self.assertEquals(0, len(results.failures)) 138 self.assertEquals(0, len(results.failures))
138 139
139 mostly_smooth = results.FindAllPageSpecificValuesNamed('mostly_smooth') 140 percentage_smooth = results.FindAllPageSpecificValuesNamed(
140 self.assertEquals(len(mostly_smooth), 1) 141 'percentage_smooth')
141 self.assertGreaterEqual(mostly_smooth[0].GetRepresentativeNumber(), 0) 142 self.assertEquals(len(percentage_smooth), 1)
143 self.assertGreaterEqual(percentage_smooth[0].GetRepresentativeNumber(), 0)
142 144
143 def testCleanUpTrace(self): 145 def testCleanUpTrace(self):
144 self.TestTracingCleanedUp(smoothness.Smoothness, self._options) 146 self.TestTracingCleanedUp(smoothness.Smoothness, self._options)
145 147
146 def testCleanUpPowerMetric(self): 148 def testCleanUpPowerMetric(self):
147 class FailPage(page.Page): 149 class FailPage(page.Page):
148 def __init__(self, page_set): 150 def __init__(self, page_set):
149 super(FailPage, self).__init__( 151 super(FailPage, self).__init__(
150 url='file://blank.html', 152 url='file://blank.html',
151 page_set=page_set, base_dir=page_set.base_dir) 153 page_set=page_set, base_dir=page_set.base_dir)
(...skipping 18 matching lines...) Expand all
170 self.fake_power = self._power_metric = FakePowerMetric(platform) 172 self.fake_power = self._power_metric = FakePowerMetric(platform)
171 173
172 measurement = BuggyMeasurement() 174 measurement = BuggyMeasurement()
173 try: 175 try:
174 self.RunMeasurement(measurement, ps) 176 self.RunMeasurement(measurement, ps)
175 except page_test.TestNotSupportedOnPlatformFailure: 177 except page_test.TestNotSupportedOnPlatformFailure:
176 pass 178 pass
177 179
178 self.assertTrue(measurement.fake_power.start_called) 180 self.assertTrue(measurement.fake_power.start_called)
179 self.assertTrue(measurement.fake_power.stop_called) 181 self.assertTrue(measurement.fake_power.stop_called)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698