Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 645743003: Use C++11 range-based loop for core/css (Closed)

Created:
6 years, 2 months ago by kochi
Modified:
6 years, 2 months ago
Reviewers:
hayato
CC:
blink-reviews, kenneth.christiansen, jfernandez, Yoav Weiss, svillar, blink-reviews-css, Manuel Rego, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Use C++11 range-based loop for core/css BUG=none TEST=no layout test failure Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183644

Patch Set 1 #

Patch Set 2 : better variable names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -96 lines) Patch
M Source/core/css/CSSCanvasValue.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/CSSGridTemplateAreasValue.cpp View 1 1 chunk +7 lines, -9 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M Source/core/css/ElementRuleCollector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceCache.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 3 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/FontLoader.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/MediaQueryList.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaQueryMatcher.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/RemoteFontFaceSource.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/RuleSet.cpp View 1 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/css/SelectorChecker.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/css/StyleSheetContents.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/TreeBoundaryCrossingRules.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kochi
Hayato-san, please review this at your leisure (ie, this is not urgent).
6 years, 2 months ago (2014-10-10 05:46:43 UTC) #2
hayato
LGTM
6 years, 2 months ago (2014-10-14 04:14:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645743003/190001
6 years, 2 months ago (2014-10-14 04:17:48 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 05:56:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:190001) as 183644

Powered by Google App Engine
This is Rietveld 408576698