Content Shell: Introduce LayoutTestBrowserMainParts.

Content Shell: Introduce LayoutTestBrowserMainParts.

This patch moves the DRT-specific bits of ShellBrowserMainParts out into
a layout-test-specific subclass.

BUG=420994
Committed: https://crrev.com/36b11b6f5e533b384f45baa0d7833f1ab2bf1d2c
Cr-Commit-Position: refs/heads/master@{#299693}

[Mike West, 2014-10-10 12:38:03]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2014-10-10 12:38:04]

Moar.

[jochen (gone - plz use gerrit), 2014-10-13 08:01:49]

https://codereview.chromium.org/645713003/diff/100001/content/shell/browser/s...
File content/shell/browser/shell_browser_main_parts.h (right):

https://codereview.chromium.org/645713003/diff/100001/content/shell/browser/s...
content/shell/browser/shell_browser_main_parts.h:60:
scoped_ptr<ShellBrowserContext> browser_context_;
can you add a protected getter/setter instead?

https://codereview.chromium.org/645713003/diff/100001/content/shell/browser/s...
content/shell/browser/shell_browser_main_parts.h:61:
scoped_ptr<ShellBrowserContext> off_the_record_browser_context_;
i'm somewhat surprised that the layout tests should need OTR profiles?

[Mike West, 2014-10-13 09:52:26]

https://codereview.chromium.org/645713003/diff/100001/content/shell/browser/s...
File content/shell/browser/shell_browser_main_parts.h (right):

https://codereview.chromium.org/645713003/diff/100001/content/shell/browser/s...
content/shell/browser/shell_browser_main_parts.h:60:
scoped_ptr<ShellBrowserContext> browser_context_;
On 2014/10/13 08:01:49, jochen wrote:
> can you add a protected getter/setter instead?

Sure.

https://codereview.chromium.org/645713003/diff/100001/content/shell/browser/s...
content/shell/browser/shell_browser_main_parts.h:61:
scoped_ptr<ShellBrowserContext> off_the_record_browser_context_;
On 2014/10/13 08:01:49, jochen wrote:
> i'm somewhat surprised that the layout tests should need OTR profiles?

It's not clear that they do.

That said, I think it would be more surprising to create a
LayoutTestBrowserContext for the recorded context, and a ShellBrowserContext for
the OTR context. *shrug* I don't feel at all strongly about it, though. If you'd
like me to drop that assignment, I'll certainly do it.

[jochen (gone - plz use gerrit), 2014-10-14 13:30:13]

just make the otr context in layout tests NULL?

otr contexts are only used by content_browsertests

[Mike West, 2014-10-14 13:37:36]

On 2014/10/14 13:30:13, jochen wrote:
> just make the otr context in layout tests NULL?
> 
> otr contexts are only used by content_browsertests

Sure, should be safe. Let's see what the bots say.

[Mike West, 2014-10-14 14:48:36]

Bots look happy. How about you?

[jochen (gone - plz use gerrit), 2014-10-15 15:21:33]

fair enough

lgtm

on android, we don't controll the main message loop from C++. however, for
layout tests, we just run a main message loop in a single task (which is kinda
cheating, and one of the reasons, layout tests on android don't work that well)

[Mike West, 2014-10-15 15:37:44]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-10-15 15:38:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/645713003/300001

[commit-bot: I haz the power, 2014-10-15 16:19:05]

Committed patchset #4 (id:300001)

[commit-bot: I haz the power, 2014-10-15 16:19:53]

Patchset 4 (id:??) landed as
https://crrev.com/36b11b6f5e533b384f45baa0d7833f1ab2bf1d2c
Cr-Commit-Position: refs/heads/master@{#299693}