Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 645693006: Updated Chrome Apps codelab (Closed)

Created:
6 years, 2 months ago by mkearney1
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updated Chrome Apps codelab Renato Mangini wrote the new codelab. Pearl Chen created cl: https://codereview.chromium.org/609433003/. I couldn't use her patch, so I created a new one manually, made edits, and am ready to launch this. Committed: https://crrev.com/18ae1155252b57eb9464d9e17a3b1862c8a53fb0 Cr-Commit-Position: refs/heads/master@{#300126}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2351 lines, -2061 lines) Patch
M chrome/common/extensions/docs/static/css/out/site.css View 1 chunk +1 line, -1 line 2 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/alarm-console-logs.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/alarms-getAll-console.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/app-tutorial-files.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/chrome-apps-finished-project.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/console-log.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/copy-todomvc.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/csp-console-error.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/enable-developer-mode.gif View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/get-set-in-console.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/icon_128.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/inspect-background-page.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/inspect-element.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/load-unpacked-extensions.gif View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/localStorage-console-error.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/notification-example.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/remove-todo-console-error.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/replace-index.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/step1-completed.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/step2-completed.gif View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/step3-completed.gif View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/step4-completed.gif View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/step5-completed.gif View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/step6-completed.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/step7-completed View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/todomvc-copied.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/webstore-draft.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/webstore-file-picker.jpg View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/webstore-promotional.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/webstore-publish.png View Binary file 0 comments Download
A chrome/common/extensions/docs/static/images/app_codelab/webview-example.png View Binary file 0 comments Download
M chrome/common/extensions/docs/static/sass/_article.scss View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab.html View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab1_setup.html View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab2_basic.html View 1 chunk +0 lines, -137 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab3_mvc.html View 1 chunk +0 lines, -428 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab5_data.html View 1 chunk +0 lines, -432 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab6_lifecycle.html View 1 chunk +0 lines, -215 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab7_useridentification.html View 1 chunk +0 lines, -190 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab8_webresources.html View 1 chunk +0 lines, -465 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_codelab_10_publishing.html View 1 chunk +0 lines, -61 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/app_codelab_alarms.html View 1 chunk +427 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/app_codelab_basics.html View 1 chunk +231 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/app_codelab_filesystem.html View 1 1 chunk +271 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/app_codelab_images.html View 1 chunk +225 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/app_codelab_import_todomvc.html View 1 chunk +745 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/app_codelab_intro.html View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/app_codelab_mobile.html View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/app_codelab_publish.html View 1 chunk +103 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/articles/app_codelab_webview.html View 1 chunk +261 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 chunk +17 lines, -17 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_codelab.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_codelab1_setup.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_codelab2_basic.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_codelab3_mvc.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_codelab5_data.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_codelab6_lifecycle.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_codelab7_useridentification.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_codelab8_webresources.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/app_codelab_10_publishing.html View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_codelab_alarms.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_codelab_basics.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_codelab_filesystem.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_codelab_images.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_codelab_import_todomvc.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_codelab_intro.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_codelab_mobile.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_codelab_publish.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/app_codelab_webview.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/public/apps/redirects.json View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
stamp lgtm https://codereview.chromium.org/645693006/diff/20001/chrome/common/extensions/docs/static/css/out/site.css File chrome/common/extensions/docs/static/css/out/site.css (right): https://codereview.chromium.org/645693006/diff/20001/chrome/common/extensions/docs/static/css/out/site.css#newcode4 chrome/common/extensions/docs/static/css/out/site.css:4: */article,aside,details,figcaption,figure,footer,header,hgroup,main,nav,section,summary{display:block}audio,canvas,video{display:inline-block;*display:inline;*zoom:1}audio:not([controls]){display:none;height:0}[hidden],template{display:none}html{font-family:sans-serif;font-size:100%;-ms-text-size-adjust:100%;-webkit-text-size-adjust:100%}button,input,select,textarea{font-family:sans-serif}body{margin:0}a{background:transparent}a:focus{outline:thin dotted}a:active,a:hover{outline:0}p,pre{margin:1.5em 0}blockquote{margin:1.5em 40px}h1{font-size:2em;line-height:1.5em;margin-top:0.75em;margin-bottom:0.75em}h2{font-size:1.5em;line-height:2em;margin-top:1em;margin-bottom:1em}h3{font-size:1.17em;line-height:1.28205em;margin-top:1.28205em;margin-bottom:1.28205em}h4{font-size:1em;line-height:1.5em;margin-top:1.5em;margin-bottom:1.5em}h5{font-size:0.83em;line-height:1.80723em;margin-top:1.80723em;margin-bottom:1.80723em}h6{font-size:0.67em;line-height:2.23881em;margin-top:2.23881em;margin-bottom:2.23881em}abbr[title]{border-bottom:1px dotted}b,strong{font-weight:bold}dfn{font-style:italic}hr{-webkit-box-sizing:content-box;-moz-box-sizing:content-box;box-sizing:content-box;height:0}mark{background:#ff0;color:#000}code,kbd,pre,samp{font-family:monospace, serif;_font-family:'courier new', ...
6 years, 2 months ago (2014-10-16 23:40:50 UTC) #2
mkearney1
https://codereview.chromium.org/645693006/diff/20001/chrome/common/extensions/docs/static/css/out/site.css File chrome/common/extensions/docs/static/css/out/site.css (right): https://codereview.chromium.org/645693006/diff/20001/chrome/common/extensions/docs/static/css/out/site.css#newcode4 chrome/common/extensions/docs/static/css/out/site.css:4: */article,aside,details,figcaption,figure,footer,header,hgroup,main,nav,section,summary{display:block}audio,canvas,video{display:inline-block;*display:inline;*zoom:1}audio:not([controls]){display:none;height:0}[hidden],template{display:none}html{font-family:sans-serif;font-size:100%;-ms-text-size-adjust:100%;-webkit-text-size-adjust:100%}button,input,select,textarea{font-family:sans-serif}body{margin:0}a{background:transparent}a:focus{outline:thin dotted}a:active,a:hover{outline:0}p,pre{margin:1.5em 0}blockquote{margin:1.5em 40px}h1{font-size:2em;line-height:1.5em;margin-top:0.75em;margin-bottom:0.75em}h2{font-size:1.5em;line-height:2em;margin-top:1em;margin-bottom:1em}h3{font-size:1.17em;line-height:1.28205em;margin-top:1.28205em;margin-bottom:1.28205em}h4{font-size:1em;line-height:1.5em;margin-top:1.5em;margin-bottom:1.5em}h5{font-size:0.83em;line-height:1.80723em;margin-top:1.80723em;margin-bottom:1.80723em}h6{font-size:0.67em;line-height:2.23881em;margin-top:2.23881em;margin-bottom:2.23881em}abbr[title]{border-bottom:1px dotted}b,strong{font-weight:bold}dfn{font-style:italic}hr{-webkit-box-sizing:content-box;-moz-box-sizing:content-box;box-sizing:content-box;height:0}mark{background:#ff0;color:#000}code,kbd,pre,samp{font-family:monospace, serif;_font-family:'courier new', monospace;font-size:1em}pre{white-space:pre;white-space:pre-wrap;word-wrap:break-word}q{quotes:"\201C" "\201D" ...
6 years, 2 months ago (2014-10-17 17:19:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/645693006/20001
6 years, 2 months ago (2014-10-17 17:23:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 17:47:32 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 17:48:37 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18ae1155252b57eb9464d9e17a3b1862c8a53fb0
Cr-Commit-Position: refs/heads/master@{#300126}

Powered by Google App Engine
This is Rietveld 408576698